Skip to content

filter: clarify comment #13678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asraa merged 9 commits into from
Oct 27, 2020
Merged

filter: clarify comment #13678

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b4ba91f
filter: clarify comment
Oct 21, 2020
2ab7c30
clang-format
Oct 21, 2020
1a6d10e
Revert "clang-format"
Oct 22, 2020
556a937
Revert "filter: clarify comment"
Oct 22, 2020
032fddf
2nd attempt
Oct 22, 2020
3800ca2
@asraa's feedback
Oct 22, 2020
b25f1bc
Merge remote-tracking branch 'upstream/master' into fix-comment-filte…
Oct 22, 2020
aa5200a
Add as similar note to FilterDataStatus::StopIterationNoBuffer
Oct 22, 2020
51d7f1d
Merge remote-tracking branch 'upstream/master' into fix-comment-filte…
Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/envoy/http/filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,13 @@ namespace Http {
enum class FilterHeadersStatus {
// Continue filter chain iteration.
Continue,
// Do not iterate to any of the remaining filters in the chain. Returning
// Do not iterate for headers to any of the remaining filters in the chain. Returning
Comment thread
asraa marked this conversation as resolved.
Outdated
// FilterDataStatus::Continue from decodeData()/encodeData() or calling
// continueDecoding()/continueEncoding() MUST be called if continued filter iteration is desired.
//
// Note that if a local reply was sent, not further iteration for headers as well as data and
Comment thread
rgs1 marked this conversation as resolved.
Outdated
// trailers for the current filter and the filters following will happen. A local reply can be
// triggered via sendLocalReply() or encodeHeaders().
Comment thread
rgs1 marked this conversation as resolved.
StopIteration,
// Continue headers iteration to remaining filters, but delay ending the stream. This status MUST
// NOT be returned when end_stream is already set to false.
Expand Down