Merged
Conversation
The comment currently states that after returning FilterHeadersStatus::StopIteration, decodeData() or encodeData() might still be called which isn't possible since the filter chain is stopped. The only way to unblock the the chain is via continueDecoding() or continueEncoding() from some callback. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
asraa
suggested changes
Oct 21, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks! I wonder if this was a copy paste snafu from FilterDataStatus's comments. 😮
Could you check spelling please?
/wait
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
ah, it was clang-format not spelling. updated -- thanks! |
Member
Author
|
The macos failure is not format nor spelling, seems transient. |
Member
|
/retest |
|
Retrying Azure Pipelines. |
lizan
suggested changes
Oct 22, 2020
added 3 commits
October 22, 2020 12:51
This reverts commit 2ab7c30. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This reverts commit b4ba91f. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
* note that StopIteration refers only to header processing (data/body processing still moves forward) * however, if a local reply is sent than StopIteration stops headers/data/trailers for all filters Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
asraa
reviewed
Oct 22, 2020
added 2 commits
October 22, 2020 14:20
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
lizan
previously approved these changes
Oct 22, 2020
lizan
reviewed
Oct 22, 2020
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
asraa
approved these changes
Oct 26, 2020
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Nov 25, 2020
Follow-up to envoyproxy#13678. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
mattklein123
pushed a commit
that referenced
this pull request
Nov 28, 2020
Follow-up to #13678. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment currently states that after returning
FilterHeadersStatus::StopIteration, decodeData() or encodeData() might
still be called which isn't possible since the filter chain is stopped.
The only way to unblock the chain is via continueDecoding() or
continueEncoding() from some callback.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com