ci: stop building alpine-debug images in favor of ubuntu-based debug image#13598
Merged
lizan merged 2 commits intoenvoyproxy:masterfrom Oct 15, 2020
Merged
ci: stop building alpine-debug images in favor of ubuntu-based debug image#13598lizan merged 2 commits intoenvoyproxy:masterfrom
lizan merged 2 commits intoenvoyproxy:masterfrom
Conversation
…image Signed-off-by: Lizan Zhou <lizan@tetrate.io>
mattklein123
requested changes
Oct 15, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for jumping on this!
/wait
ci/README.md
Outdated
| Minimal images based on Alpine Linux allow for quicker deployment of Envoy. Two Alpine based images are built, | ||
| one with an Envoy binary with debug (`envoyproxy/envoy-alpine-debug`) symbols and one stripped of them (`envoyproxy/envoy-alpine`). | ||
| Both images are pushed with two different tags: `<hash>` and `latest`. Parallel to the Ubuntu images above, `<hash>` corresponds to the | ||
| Minimal images based on Alpine Linux allow for quicker deployment of Envoy. The Alpine base image are only built with symbol stripped. |
Member
There was a problem hiding this comment.
Suggested change
| Minimal images based on Alpine Linux allow for quicker deployment of Envoy. The Alpine base image are only built with symbol stripped. | |
| Minimal images based on Alpine Linux allow for quicker deployment of Envoy. The Alpine base image is only built with symbols stripped. |
| binary with debug symbols on top of an Ubuntu Bionic base. | ||
| * `envoyproxy/envoy-alpine <https://hub.docker.com/r/envoyproxy/envoy-alpine/tags/>`_: Release | ||
| binary with symbols stripped on top of a **glibc** alpine base. | ||
| * `envoyproxy/envoy-alpine-debug <https://hub.docker.com/r/envoyproxy/envoy-alpine-debug/tags/>`_: |
Member
There was a problem hiding this comment.
Release note also? Or did we already release note this? I can't remember.
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This was referenced Oct 15, 2020
Merged
htuch
approved these changes
Oct 15, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 17, 2020
* master: (22 commits) delay health checks until transport socket secrets are ready. (envoyproxy#13516) test, oauth2: Make sure config test runs field validation (envoyproxy#13496) [http] swap codec implementations to default new (envoyproxy#13579) wasm: update proxy-wasm-cpp-host (envoyproxy#13606) postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393) configs: Update configs v2 -> v3 (envoyproxy#13562) http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546) dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571) listener: add match all filter chain (envoyproxy#13449) fix mistakes in docstrings (envoyproxy#13603) ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269) cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783) ext_authz: Avoid calling check multiple times (envoyproxy#13288) docs: Unexclude remaining configs from validation (envoyproxy#13534) build: update rules_rust to allow Rustc in RBE (envoyproxy#13595) docs: Update sphinxext.rediraffe (envoyproxy#13589) Deprecate moonjit support on Windows before beta (envoyproxy#13541) dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474) docs: add TLS stats to cluster stats doc (envoyproxy#13561) ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
lizan
added a commit
that referenced
this pull request
Oct 21, 2020
Backport following commits to 1.16: 748b2ab (mac ci: try ignoring update failure (#13658), 2020-10-20) f95f539 (ci: various improvements (#13660), 2020-10-20) 6481a27 (ci: stop building alpine-debug images in favor of ubuntu-based debug image (#13598), 2020-10-15) 73d78f8 (ci: use multiple stage (#13557), 2020-10-15) b7a4756 (ci: use azp for api and go-control-plane sync (#13550), 2020-10-14) 876a6bb (ci use azp to sync filter example (#13501), 2020-10-12) a0f31ee (ci: use azp to generate docs (#13481), 2020-10-12) 7e5d854 (ci: bring BAZEL_BUILD_OPTIONS back for format and docs (#13480), 2020-10-11) 7af2b2b (ci: use same flaky test process script on macOS (#13485), 2020-10-10) Signed-off-by: Lizan Zhou <lizan@tetrate.io> Co-authored-by: asraa <asraa@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Additional Description:
Stop building the deprecated image for CI speed up and space saving.
Risk Level: Low
Testing:
Docs Changes: Done
Release Notes: