ratelimit: add route entry metadata to ratelimit actions by andrascz · Pull Request #13269 · envoyproxy/envoy

andrascz · 2020-09-25T12:52:34Z

Commit Message: Modifies ratelimit filter to be able to use information
from the route's filter metadata as one of its actions with a route_entry_metadata action
configurable the same way as dynamic_metadata

Signed-off-by: András Czigány andras.czigany@strivacity.com
Additional Description:
Risk Level: Low
Testing: unit tests
Docs Changes: proto files and current version changelog
Release Notes: N/A see docs changes
Fixes #12556

edit: filter_metadata -> route_entry_metadata

Modifies ratelimit filter to be able to use information from the route's filter metadata as one of its actions Signed-off-by: András Czigány <andras.czigany@strivacity.com>

repokitteh-read-only · 2020-09-25T12:52:39Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #13269 was opened by andrascz.

see: more, trace.

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

htuch

/wait

api/envoy/config/route/v3/route_components.proto

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

htuch

LGTM, thanks!

junr03

Thanks, a few comments

api/envoy/config/route/v3/route_components.proto

source/common/router/router_ratelimit.cc

api/envoy/config/route/v3/route_components.proto

test/common/router/router_ratelimit_test.cc

junr03 · 2020-09-29T17:45:59Z

/wait

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

mattklein123

One API question. Thank you!

/wait-any

api/envoy/config/route/v3/route_components.proto

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

mattklein123

Thanks looks great. Just one small comment.

/wait

api/envoy/config/route/v3/route_components.proto

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

test/common/router/router_ratelimit_test.cc

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

mattklein123

Nice, thanks!

* master: (22 commits) delay health checks until transport socket secrets are ready. (envoyproxy#13516) test, oauth2: Make sure config test runs field validation (envoyproxy#13496) [http] swap codec implementations to default new (envoyproxy#13579) wasm: update proxy-wasm-cpp-host (envoyproxy#13606) postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393) configs: Update configs v2 -> v3 (envoyproxy#13562) http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546) dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571) listener: add match all filter chain (envoyproxy#13449) fix mistakes in docstrings (envoyproxy#13603) ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269) cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783) ext_authz: Avoid calling check multiple times (envoyproxy#13288) docs: Unexclude remaining configs from validation (envoyproxy#13534) build: update rules_rust to allow Rustc in RBE (envoyproxy#13595) docs: Update sphinxext.rediraffe (envoyproxy#13589) Deprecate moonjit support on Windows before beta (envoyproxy#13541) dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474) docs: add TLS stats to cluster stats doc (envoyproxy#13561) ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>

ratelimit: add filter metadata to ratelimit actions

737219a

Modifies ratelimit filter to be able to use information from the route's filter metadata as one of its actions Signed-off-by: András Czigány <andras.czigany@strivacity.com>

repokitteh-read-only bot added the api label Sep 25, 2020

dio assigned junr03 Sep 25, 2020

fixup! ratelimit: add filter metadata to ratelimit actions

95da873

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

htuch suggested changes Sep 27, 2020

View reviewed changes

api/envoy/config/route/v3/route_components.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Sep 27, 2020

andrascz requested a review from htuch September 28, 2020 08:09

andrascz changed the title ~~ratelimit: add filter metadata to ratelimit actions~~ ratelimit: add route entry metadata to ratelimit actions Sep 28, 2020

rename filter_metadata to route_entry_metadata

3c90d40

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

repokitteh-read-only bot removed the waiting label Sep 28, 2020

andrascz added 2 commits September 28, 2020 11:08

Merge branch 'master' of github.com:envoyproxy/envoy into filter-meta…

ac7023c

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

route_components.proto: min_bytes -> min_len

2550c95

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

htuch previously approved these changes Sep 29, 2020

View reviewed changes

repokitteh-read-only bot removed the api label Sep 29, 2020

junr03 reviewed Sep 29, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label Sep 29, 2020

andrascz added 2 commits September 30, 2020 09:58

fixup! rename filter_metadata to route_entry_metadata

5f8ddb9

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

Merge branch 'master' of github.com:envoyproxy/envoy into filter-meta…

2c84d8c

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

andrascz dismissed htuch’s stale review via 2c84d8c September 30, 2020 08:01

repokitteh-read-only bot added api and removed waiting labels Sep 30, 2020

andrascz added 2 commits October 8, 2020 12:32

router_ratelimit_test: fix test names

87d6b06

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

route_components.proto: link to metadata docs

07e96d7

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

andrascz requested a review from junr03 October 8, 2020 12:41

andrascz added 4 commits October 9, 2020 11:45

Merge branch 'master' of github.com:envoyproxy/envoy into filter-meta…

1c96988

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

current.rst: fix after 1.16.0 release

cebfd19

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

fixup! current.rst: fix after 1.16.0 release

e09c921

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

fixup! rename filter_metadata to route_entry_metadata

122dd12

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

current.rst: fix after pull

e1ed2f7

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

junr03 previously approved these changes Oct 13, 2020

View reviewed changes

mattklein123 reviewed Oct 14, 2020

View reviewed changes

api/envoy/config/route/v3/route_components.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting:any label Oct 14, 2020

mattklein123 self-assigned this Oct 14, 2020

Merge branch 'master' of github.com:envoyproxy/envoy into filter-meta…

15a22d3

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

andrascz dismissed junr03’s stale review via 15a22d3 October 14, 2020 06:48

repokitteh-read-only bot added waiting and removed waiting:any labels Oct 14, 2020

andrascz added 2 commits October 14, 2020 17:43

Merge branch 'master' of github.com:envoyproxy/envoy into filter-meta…

82b42da

…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>

ratelimit: generic metadata action

de6857b

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

repokitteh-read-only bot removed the waiting label Oct 15, 2020

mattklein123 requested changes Oct 15, 2020

View reviewed changes

api/envoy/config/route/v3/route_components.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Oct 15, 2020

ratelimit: deprecate dynamic_metadata action

e2f7016

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

repokitteh-read-only bot removed the waiting label Oct 15, 2020

andrascz requested a review from mattklein123 October 15, 2020 18:23

router_ratelimit_test.cc: fix metadata action tests

edb9511

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

andrascz commented Oct 15, 2020

View reviewed changes

test/common/router/router_ratelimit_test.cc Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Oct 15, 2020

fixup! router_ratelimit_test.cc: fix metadata action tests

4f28c09

Signed-off-by: András Czigány <andras.czigany@strivacity.com>

repokitteh-read-only bot removed the waiting label Oct 16, 2020

mattklein123 approved these changes Oct 16, 2020

View reviewed changes

repokitteh-read-only bot removed the api label Oct 16, 2020

mattklein123 merged commit 06813b2 into envoyproxy:master Oct 16, 2020

andrascz deleted the filter-metadata-ratelimit-action branch October 16, 2020 15:37

RiverPhillips mentioned this pull request Jan 24, 2023

Support Route Entry Metadata in External Authorization Filter #25134

Closed

henrymwang mentioned this pull request Jun 25, 2024

Support matching route metadata in the HTTP RBAC filter #34913

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ratelimit: add route entry metadata to ratelimit actions#13269

ratelimit: add route entry metadata to ratelimit actions#13269
mattklein123 merged 21 commits intoenvoyproxy:masterfrom
Strivacity:filter-metadata-ratelimit-action

andrascz commented Sep 25, 2020 •

edited

Loading

Uh oh!

repokitteh-read-only bot commented Sep 25, 2020

Uh oh!

htuch left a comment

Uh oh!

Uh oh!

htuch left a comment

Uh oh!

junr03 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junr03 commented Sep 29, 2020

Uh oh!

mattklein123 left a comment

Uh oh!

Uh oh!

mattklein123 left a comment

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

andrascz commented Sep 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Sep 25, 2020

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

junr03 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junr03 commented Sep 29, 2020

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andrascz commented Sep 25, 2020 •

edited

Loading