Skip to content

Skylark function for basic cc_library envoy targets #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Jul 24, 2017
Merged

Skylark function for basic cc_library envoy targets #1322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3fcc9d
Added skylark function for envoy targets that currently call cc_libra…
mrice32 Jul 24, 2017
8aaf35f
updated name and corrected a few minor issues
mrice32 Jul 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bazel/envoy_build_system.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ def envoy_include_prefix(path):
return '/'.join(path.split('/')[1:])
return None

# Envoy C++ library targets that need no transformations or additional dependencies before being
# passed to cc_library should be specified with this function. Note: this exists to ensure that
# all envoy targets pass through an envoy-declared skylark function where they can be modified
# before being passed to a native bazel function.
def basic_envoy_cc_library(name, **kargs):

@htuch htuch Jul 24, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: prefer envoy_basic_cc_library, since all other macros we provide are envoy_ prefixed.

@mrice32 mrice32 Jul 24, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will update.

native.cc_library(name = name, **kwargs)

# Envoy C++ library targets should be specified with this function.
def envoy_cc_library(name,
srcs = [],
Expand Down
2 changes: 1 addition & 1 deletion include/envoy/common/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ load(

envoy_package()

cc_library(
basic_envoy_cc_library(
name = "base_includes",
hdrs = [
"exception.h",
Expand Down
2 changes: 1 addition & 1 deletion test/test_common/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ load(

envoy_package()

cc_library(
basic_envoy_cc_library(
name = "printers_includes",
hdrs = ["printers.h"],
)
Expand Down