Skylark function for basic cc_library envoy targets#1322
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jul 24, 2017
Merged
Skylark function for basic cc_library envoy targets#1322mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Member
Author
|
cc @htuch |
htuch
reviewed
Jul 24, 2017
bazel/envoy_build_system.bzl
Outdated
| # passed to cc_library should be specified with this function. Note: this exists to ensure that | ||
| # all envoy targets pass through an envoy-declared skylark function where they can be modified | ||
| # before being passed to a native bazel function. | ||
| def basic_envoy_cc_library(name, **kargs): |
Member
There was a problem hiding this comment.
Nit: prefer envoy_basic_cc_library, since all other macros we provide are envoy_ prefixed.
Member
Author
There was a problem hiding this comment.
Good point. Will update.
mattklein123
approved these changes
Jul 24, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Sanitize JWT verification result in HTTP headers **What this PR does / why we need it**: To defend the attack of injecting forged JWT verification results in HTTP headers, sanitize the JWT verification result when jwt_auth filter starts. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#1321 **Special notes for your reviewer**: **Release note**: ```release-note ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: adds execution of string accessor code path to the swift and kotlin example apps. Risk Level: low Testing: adds new testing via c++ filter. Fixes #1317 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: adds execution of string accessor code path to the swift and kotlin example apps. Risk Level: low Testing: adds new testing via c++ filter. Fixes #1317 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Currently, there is subtle request memory corruption due to sjson ReplaceInPlace usage. sjson modifies the original buffer when ReplaceInPlace is set. This causes request memory corruption during sjson.SetBytesOption calls to replace string(eg: model overwrite). This issue is always consistently reproducible in fallback mode. It happens in other cases as well but not evident as original request is not reused. --------- Signed-off-by: Johnu George <johnugeorge109@gmail.com> Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added skylark function for envoy targets that currently call cc_library directly. This will help us, in particular, with our import. It should also be generally useful so that all envoy targets go through a skylark function declared in
bazel/envoy_build_system.bzlallowing easy modifications of general classes of targets.