Skip to content

Replace old MOCK_METHOD macros #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 1 commit into from
Sep 21, 2020
Merged

Replace old MOCK_METHOD macros #13186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extensions/filters/common/lua/lua_wrappers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Lua {
// A helper to be called inside the registered closure.
class Printer {
public:
MOCK_CONST_METHOD1(testPrint, void(const std::string&));
MOCK_METHOD(void, testPrint, (const std::string&), (const));
};

const Printer& getPrinter() { CONSTRUCT_ON_FIRST_USE(Printer); }
Expand Down
6 changes: 3 additions & 3 deletions test/mocks/stats/mocks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,9 @@ class MockTextReadout : public MockMetric<TextReadout> {
MockTextReadout();
~MockTextReadout() override;

MOCK_METHOD1(set, void(absl::string_view value));
MOCK_CONST_METHOD0(used, bool());
MOCK_CONST_METHOD0(value, std::string());
MOCK_METHOD(void, set, (absl::string_view value), (override));
MOCK_METHOD(bool, used, (), (const, override));
MOCK_METHOD(std::string, value, (), (const, override));

bool used_;
std::string value_;
Expand Down