Replace old MOCK_METHOD macros#13186
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 21, 2020
tbarrella:mock-method
Merged
Replace old MOCK_METHOD macros#13186mattklein123 merged 1 commit intoenvoyproxy:masterfrom tbarrella:mock-method
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
tbarrella:mock-method
Conversation
As recommended in https://github.com/google/googletest/blob/release-1.10.0/googlemock/docs/cook_book.md#old-style-mock_methodn-macros Signed-off-by: Taylor Barrella <tabarr@google.com>
yanavlasov
approved these changes
Sep 18, 2020
akonradi
added a commit
to akonradi/envoy
that referenced
this pull request
Dec 16, 2020
This is a continuation of envoyproxy#13186 Signed-off-by: Alex Konradi <akonradi@google.com>
alyssawilk
pushed a commit
that referenced
this pull request
Dec 17, 2020
Commit Message: Replace MOCK_METHODn with MOCK_METHOD Additional Description: This is a continuation of #13186, but with an additional format check to prevent additions of MOCK_METHODn invocations in the future. Risk Level: low Testing: built affected targets Docs Changes: n/a Release Notes: n/a Platform Specific Features: none Signed-off-by: Alex Konradi <akonradi@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Replace old MOCK_METHOD macros
Additional Description: As recommended in https://github.com/google/googletest/blob/release-1.10.0/googlemock/docs/cook_book.md#old-style-mock_methodn-macros
Risk Level: Low
Testing: unit test
Docs Changes: N/A
Release Notes: N/A