[ci] fix per-file coverage#13030
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
|
Had to reduce watchdog coverage in the interim, fixed now. |
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
|
I'm really sorry about this but source/common/common regressed by .1 in the last commit is as well. Current post-submit works with the script now, I'll ping when I have all green checks. |
|
Yeah, this was annoying to get in last time too - I think it took me several tries and I snuck it in off hours. |
|
I'm happy to force merge but then I think main will be broken, but then we can do a fast follow. Up to you. |
|
If she runs off the current coverage.dat it'll be as up to date as it's likely to get. Either way any PR which has passed presubmit but merges without a refresh is going to risk breaking things for a day or so :-/ |
|
If this try doesn't work, I'm happy to sneak this in after work hours tonight and ping maintainer chat to see if someone's online to approve. |
Commit Message: Fix per file extension coverage in CI
Additional Description: Filed issues for new low coverage extensions
Risk Level: Low
Testing: currently testing with docker bazel.coverage after fixing known low coverage, but i admit it takes > 1 hour to run locally. so i'm keeping that running
Filed issues for new watchdog, ocsp oath2 extensions
Self assigned HCM config coverage issue
dynamic_forward_proxy's regressed but the uncovered lines are trivial (https://storage.googleapis.com/envoy-postsubmit/master/coverage/source/extensions/filters/http/dynamic_forward_proxy/proxy_filter.cc.gcov.html)
all others extensions have existing issues
Signed-off-by: Asra Ali asraa@google.com