Skip to content

docs: Add missing bug fix release note for udp_proxy #12995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Sep 9, 2020
Merged

docs: Add missing bug fix release note for udp_proxy #12995

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c577b9
docs: Add missing bug fix release note for udp_proxy
Sep 5, 2020
3b0ec05
Address comment
Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/root/version_history/current.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Bug Fixes
* http: made the HeaderValues::prefix() method const.
* jwt_authn: supports jwt payload without "iss" field.
* rocketmq_proxy network-level filter: fixed an issue involving incorrect header lengths. In debug mode it causes crash and in release mode it causes underflow.
* udp_proxy: fixed an issue with race condition. When the udp_proxy is activated and if hot restarting is triggered, sometimes it causes crash.

@mattklein123 mattklein123 Sep 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry what issue was this again? Usually we don't do release notes for small fixes like this but if we do do one it would be good to be a bit more specific.

@chadr123 chadr123 Sep 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a fix that prevent envoy crash when hot reload is triggered.
It was caused because the udp listener was deleted first then read filter.
So, If there are some incoming packet from upstream, the Envoy try to pass packets to downstream via udp listener but there is no actual udp listener instance because it already deleted.
I hope you remember this bug again. :)

@mattklein123 mattklein123 Sep 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes I remember now! :) Let's go with:

Suggested change
* udp_proxy: fixed an issue with race condition. When the udp_proxy is activated and if hot restarting is triggered, sometimes it causes crash.
* udp_proxy: fixed a crash due to UDP packets being processed after listener removal.

?

@chadr123 chadr123 Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. That is more better. :)


Removed Config or Runtime
-------------------------
Expand Down