docs: Add missing bug fix release note for udp_proxy#12995
docs: Add missing bug fix release note for udp_proxy#12995mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
This bug fix release note should be added on envoyproxy#11914 but is was missed. Signed-off-by: DongRyeol Cha <dr83.cha@samsung.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for adding the release note, one question.
/wait
| * http: made the HeaderValues::prefix() method const. | ||
| * jwt_authn: supports jwt payload without "iss" field. | ||
| * rocketmq_proxy network-level filter: fixed an issue involving incorrect header lengths. In debug mode it causes crash and in release mode it causes underflow. | ||
| * udp_proxy: fixed an issue with race condition. When the udp_proxy is activated and if hot restarting is triggered, sometimes it causes crash. |
There was a problem hiding this comment.
Sorry what issue was this again? Usually we don't do release notes for small fixes like this but if we do do one it would be good to be a bit more specific.
There was a problem hiding this comment.
It was a fix that prevent envoy crash when hot reload is triggered.
It was caused because the udp listener was deleted first then read filter.
So, If there are some incoming packet from upstream, the Envoy try to pass packets to downstream via udp listener but there is no actual udp listener instance because it already deleted.
I hope you remember this bug again. :)
There was a problem hiding this comment.
Ah yes I remember now! :) Let's go with:
| * udp_proxy: fixed an issue with race condition. When the udp_proxy is activated and if hot restarting is triggered, sometimes it causes crash. | |
| * udp_proxy: fixed a crash due to UDP packets being processed after listener removal. |
?
There was a problem hiding this comment.
Ok. That is more better. :)
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Small comment, thank you!
/wait
| * http: made the HeaderValues::prefix() method const. | ||
| * jwt_authn: supports jwt payload without "iss" field. | ||
| * rocketmq_proxy network-level filter: fixed an issue involving incorrect header lengths. In debug mode it causes crash and in release mode it causes underflow. | ||
| * udp_proxy: fixed an issue with race condition. When the udp_proxy is activated and if hot restarting is triggered, sometimes it causes crash. |
There was a problem hiding this comment.
Ah yes I remember now! :) Let's go with:
| * udp_proxy: fixed an issue with race condition. When the udp_proxy is activated and if hot restarting is triggered, sometimes it causes crash. | |
| * udp_proxy: fixed a crash due to UDP packets being processed after listener removal. |
?
Signed-off-by: DongRyeol Cha <dr83.cha@samsung.com>
3 participants
Commit Message:
This bug fix release note should be added in #11914 but is was missed.
Signed-off-by: DongRyeol Cha dr83.cha@samsung.com
Additional Description: None
Risk Level: Low
Testing: None
Docs Changes: None
Release Notes: added in current.rst