Skip to content

fuzz: fix oss-fuzz crash in route_fuzz_test due to validation#12176

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
arthuryan-k:fix_route_crash
Jul 20, 2020
Merged

fuzz: fix oss-fuzz crash in route_fuzz_test due to validation#12176
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
arthuryan-k:fix_route_crash

Conversation

@arthuryan-k
Copy link
Contributor

Signed-off-by: Arthur Yan arthuryan@google.com

Commit Message: Fixes oss-fuzz crash (ASSERT: valid) due to validation
Additional Description:

  • Added validation that header in VirtualHost is well-formed
  • Added regression test to route_corpus

Risk Level: Low
Testing: passes regression test that originally crashed on oss-fuzz
Docs Changes: N/A
Release Notes: N/A
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24086

/cc @asraa
/cc @akonradi

Signed-off-by: Arthur Yan <arthuryan@google.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12176 was opened by arthuryan-k.

see: more, trace.

Signed-off-by: Arthur Yan <arthuryan@google.com>
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM -- thanks Alex for reviewing.

@mattklein123 mattklein123 merged commit e355c58 into envoyproxy:master Jul 20, 2020
@arthuryan-k arthuryan-k deleted the fix_route_crash branch July 21, 2020 12:44
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
…roxy#12176)

Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
…roxy#12176)

Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants