test: fix typos and make cleanups in router tests#12094
Merged
junr03 merged 1 commit intoenvoyproxy:masterfrom Jul 18, 2020
Merged
test: fix typos and make cleanups in router tests#12094junr03 merged 1 commit intoenvoyproxy:masterfrom
junr03 merged 1 commit intoenvoyproxy:masterfrom
Conversation
- Fix typos in test names. - Remove unused 'name' attribute in yaml config snippets. - Rename string variable storing yaml config to 'yaml' for consistency. Repeating the name of the test both in the variable name and in the yaml snippet has led to some copy/paste mistakes, so removing this unnecessary repetition will make these mistakes less likely to reoccur. Signed-off-by: Martin Matusiak <numerodix@gmail.com>
numerodix
commented
Jul 15, 2020
|
|
||
| TEST_F(RouteConfigurationV2, BadConnectConfig) { | ||
| const std::string yaml = R"EOF( | ||
| name: RetriableStatusCodes |
Contributor
Author
There was a problem hiding this comment.
Example of the name property not matching the test name because it was copy/pasted from another test.
junr03
approved these changes
Jul 18, 2020
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
test: fix typos and make cleanups in router tests Risk Level: low Testing: bazel test //test/... Docs Changes: n/a Release Notes: n/a Signed-off-by: Martin Matusiak <numerodix@gmail.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
test: fix typos and make cleanups in router tests Risk Level: low Testing: bazel test //test/... Docs Changes: n/a Release Notes: n/a Signed-off-by: Martin Matusiak <numerodix@gmail.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: test: fix typos and make cleanups in router tests
Additional Description:
Repeating the name of the test both in the variable name and in the yaml snippet has led to some copy/paste mistakes, so removing this unnecessary repetition will make these mistakes less likely to reoccur.
Risk Level: low
Testing: bazel test //test/...
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Martin Matusiak numerodix@gmail.com