Closed
Conversation
This reverts commit 146fb40.
Member
|
Is this revert really needed? We should be able to do 2 stage breaking changes like this since we pin the build image SHA. |
Member
Author
|
CI is fine, but it's a bit disruptive to have folks unable to run |
Member
|
Yes, agreed, by default run_envoy_docker should use the pinned SHA unless overriden. |
Member
Author
|
Obsoleted by #1211. |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Add tests for validateX509 **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: This PR contains only the header changes from #1209 which were made while developing. Risk Level: Low Testing: N/A, no behavior changes Docs Changes: N/A Release Notes: N/A Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: This PR contains only the header changes from #1209 which were made while developing. Risk Level: Low Testing: N/A, no behavior changes Docs Changes: N/A Release Notes: N/A Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This PR is fixed grpc MaxRecvMsgSize default limit. **Related Issues/PRs (if applicable)** Fixes #1209 Signed-off-by: misakazhou <misakazhou@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1205. This broke fix_format etc., since it removes clang-format-3.6. We should probably add a CI with the changes to the various scripts and format changes.