Conversation
This change just adds the binary. I will use the new image and make the format fixes in a follow up change.
Member
Author
|
@lyft/network-team @htuch |
htuch
approved these changes
Jul 5, 2017
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
I think you'll find there's probably going to be some code churn when you first switch to clang-format-5.0, even if the same clang format is used. FYI.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
) * Try Cluster warming * Fix build errors * build fix * more build * optional fix * use absl::optional * info.duration() removed * more fixes * use absl:optional in tests * Use the latest Envoy from master * Run clang-format * Even newer Envoy * Use requestComplete() instead of duration() * Fix * use requestComplete * Use value_or()
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** In standalone mode, it takes a while for the Envoy process to start. This PR adds some feedback during the Envoy startup process so that users can know when Envoy is ready to accept connections: ``` $ ./out/aigw-darwin-arm64 run --debug (...) looking up the latest patch for Envoy version 1.35 1.35.3 is already downloaded starting: /tmp/envoy-gateway/versions/1.35.3/bin/envoy in run directory /tmp/envoy-gateway/runs/1758020241848418000 [2025-09-16 12:57:22.144][18234916][warning][config] [source/server/options_impl_platform_default.cc:9] CPU number provided by HW thread count (instead of cpuset). time=2025-09-16T12:57:22.781+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:24.781+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:26.781+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:28.781+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:30.781+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:32.781+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:34.781+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:36.780+02:00 level=INFO msg="Waiting for Envoy to be ready..." status=PRE_INITIALIZING time=2025-09-16T12:57:38.782+02:00 level=INFO msg="Envoy is ready!" status=LIVE ``` **Related Issues/PRs (if applicable)** N/A **Special notes for reviewers (if applicable)** N/A Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change just adds the binary. I will use the new image and make the format
fixes in a follow up change.