-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[test]added unit test cases for network-layer filter "direct_response" #12064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zuercher
merged 5 commits into
envoyproxy:master
from
jianwen612:direct_response_unit_test
Jul 21, 2020
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
98642ab
added test cases for network-layer filter "direct_response"
jianwen612 83424f4
removed the filter from test/per_file_coverage.sh
jianwen612 76a9d91
added expectation for test `onData`
jianwen612 f24e41d
add `using testing::_`
jianwen612 033f343
Merge remote-tracking branch 'upstream/master' into direct_response_u…
jianwen612 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
test/extensions/filters/network/direct_response/direct_response_test.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| #include "envoy/extensions/filters/network/direct_response/v3/config.pb.validate.h" | ||
|
|
||
| #include "extensions/filters/network/direct_response/filter.h" | ||
|
|
||
| #include "test/mocks/api/mocks.h" | ||
| #include "test/mocks/network/mocks.h" | ||
|
|
||
| #include "gmock/gmock.h" | ||
| #include "gtest/gtest.h" | ||
|
|
||
| using testing::_; | ||
| using testing::NiceMock; | ||
|
|
||
| namespace Envoy { | ||
| namespace Extensions { | ||
| namespace NetworkFilters { | ||
| namespace DirectResponse { | ||
|
|
||
| class DirectResponseFilterTest : public testing::Test { | ||
| public: | ||
| void initialize(const std::string& response) { | ||
| filter_ = std::make_shared<DirectResponseFilter>(response); | ||
| filter_->initializeReadFilterCallbacks(read_filter_callbacks_); | ||
| } | ||
| std::shared_ptr<DirectResponseFilter> filter_; | ||
| NiceMock<Network::MockReadFilterCallbacks> read_filter_callbacks_; | ||
| }; | ||
|
|
||
| // Test the filter's onNewConnection() with a non-empty response | ||
| TEST_F(DirectResponseFilterTest, OnNewConnection) { | ||
| initialize("hello"); | ||
| Buffer::OwnedImpl response("hello"); | ||
| EXPECT_CALL(read_filter_callbacks_.connection_, write(BufferEqual(&response), false)); | ||
| EXPECT_CALL(read_filter_callbacks_.connection_, close(Network::ConnectionCloseType::FlushWrite)); | ||
| EXPECT_CALL(read_filter_callbacks_.connection_.stream_info_, | ||
| setResponseCodeDetails(StreamInfo::ResponseCodeDetails::get().DirectResponse)); | ||
| EXPECT_EQ(Network::FilterStatus::StopIteration, filter_->onNewConnection()); | ||
| } | ||
|
|
||
| // Test the filter's onNewConnection() with an empty response | ||
| TEST_F(DirectResponseFilterTest, OnNewConnectionEmptyResponse) { | ||
| initialize(""); | ||
| EXPECT_CALL(read_filter_callbacks_.connection_, write(_, _)).Times(0); | ||
| EXPECT_CALL(read_filter_callbacks_.connection_, close(Network::ConnectionCloseType::FlushWrite)); | ||
| EXPECT_CALL(read_filter_callbacks_.connection_.stream_info_, | ||
| setResponseCodeDetails(StreamInfo::ResponseCodeDetails::get().DirectResponse)); | ||
| EXPECT_EQ(Network::FilterStatus::StopIteration, filter_->onNewConnection()); | ||
| } | ||
|
|
||
| // Test the filter's onData() | ||
| TEST_F(DirectResponseFilterTest, OnData) { | ||
| initialize("hello"); | ||
| Buffer::OwnedImpl data("data"); | ||
| EXPECT_CALL(read_filter_callbacks_.connection_, write(_, _)).Times(0); | ||
| EXPECT_EQ(Network::FilterStatus::Continue, filter_->onData(data, false)); | ||
| } | ||
|
|
||
| } // namespace DirectResponse | ||
| } // namespace NetworkFilters | ||
| } // namespace Extensions | ||
| } // namespace Envoy | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.