[test]added unit test cases for network-layer filter "direct_response"#12064
Merged
zuercher merged 5 commits intoenvoyproxy:masterfrom Jul 21, 2020
Merged
[test]added unit test cases for network-layer filter "direct_response"#12064zuercher merged 5 commits intoenvoyproxy:masterfrom
zuercher merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: jianwen <jianwendong@google.com>
Signed-off-by: jianwen <jianwendong@google.com>
zuercher
reviewed
Jul 20, 2020
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Thanks. Sorry for the slow response, I was out last week.
test/extensions/filters/network/direct_response/direct_response_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: jianwen <jianwendong@google.com>
Signed-off-by: jianwen <jianwendong@google.com>
Member
|
/azp run |
|
Pull request contains merge conflicts. |
Member
|
@jianwen612 Apparently azure pipelines won't run tests if there's a merge conflict, so you'll have to merge master to get the tests passing. |
…nit_test Signed-off-by: jianwen <jianwendong@google.com>
Contributor
Author
Merged. Thanks! |
zuercher
approved these changes
Jul 21, 2020
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
Added unit test cases for "direct_response". Removed "direct_response" from test/per_file_coverage.sh Risk Level:low Testing: covered onData() and onNewConnection() method of the filter. Fixes: envoyproxy#11998 Signed-off-by: jianwen <jianwendong@google.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Added unit test cases for "direct_response". Removed "direct_response" from test/per_file_coverage.sh Risk Level:low Testing: covered onData() and onNewConnection() method of the filter. Fixes: envoyproxy#11998 Signed-off-by: jianwen <jianwendong@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Description:
[see https://github.com//issues/11998]
Added unit test cases for "direct_response".
Removed "direct_response" from test/per_file_coverage.sh
Risk Level:low
Testing:
covered onData() and onNewConnection() method of the filter.
Coverage for this filter is now 100%
[Optional Fixes #Issue] #11998
/cc @asraa
/cc @samkerner