test: remove superfluous test dependencies#11912
test: remove superfluous test dependencies#11912alyssawilk merged 3 commits intoenvoyproxy:masterfrom
Conversation
foreseeable
requested review from
alyssawilk,
lizan,
mattklein123 and
snowp
as code owners
ahedberg
left a comment
ahedberg
left a comment
There was a problem hiding this comment.
Thanks! Did we run comparisons of compile time before/after this change?
|
Nice clean up! Looks like this may have removed it from a test that needed it though - mind checking out CI? |
Signed-off-by: Muge Chen <mugechen@google.com>
@ahedberg yes, we can talk about this at the standup |
|
Would be curious to see the build-time comparison once everything is working. Did you use a tool to discover which dependencies were superfluous? |
Signed-off-by: Muge Chen <mugechen@google.com>
I will post the comparison to the issue page referred by this pr. Currently the superfluous dependencies are detected by simple keyword matching. i.e. find whether there're keyword 'Server::Mock***' appeared in the code file which includes 'test/server/mocks.h'. I wrote some scripts to refactor the code base and will upload it later. |
|
+1 would love to see numbers iff you have them handy, but this looks like an improvement either way :-) |
* Revert "test: shard http2_integration_test (envoyproxy#11939)" This reverts commit 2026ec2. * Revert "fuzz: added fuzz test for listener filter original_dst (envoyproxy#11847)" This reverts commit 673cab8. * Revert "docs: updating release instructions (envoyproxy#11938)" This reverts commit 09b96a5. * Revert "test: remove superfluous test dependencies (envoyproxy#11912)" This reverts commit 5e9fb8a. * Revert "dynamic_forward_proxy: cleanup integration test (envoyproxy#11891)" This reverts commit 11a4667. * Revert "preliminary PR to Porting Envoy to C++17 (envoyproxy#11840)" This reverts commit 9ad964d. * Revert "connection: Do not reset delayed closed timer if doWrite consumes 0 bytes from the output buffer. (envoyproxy#11833)" This reverts commit 5960533. * Revert "threadlocal: avoiding a dynamic cast in opt builds (envoyproxy#11900)" This reverts commit 363b104. * Revert "release: kicking off 1.16.0 (envoyproxy#11930)" This reverts commit ef74d8f. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Commit Message: remove superfluous includes Additional Description: The monolith mock library mocks/server/mocks.h is included by several tests but never used. Remove them to speed up building phase Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com>
Commit Message: remove superfluous includes Additional Description: The monolith mock library mocks/server/mocks.h is included by several tests but never used. Remove them to speed up building phase Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
4 participants
Signed-off-by: Muge Chen mugechen@google.com
Commit Message: remove superfluous includes
Additional Description: The monolith mock library mocks/server/mocks.h is included by several tests but never used. Remove them to speed up building phase
Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917
/cc @ahedberg