fuzz: added fuzz test for listener filter original_dst#11847
Merged
asraa merged 15 commits intoenvoyproxy:masterfrom Jul 8, 2020
Merged
fuzz: added fuzz test for listener filter original_dst#11847asraa merged 15 commits intoenvoyproxy:masterfrom
asraa merged 15 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
akonradi
suggested changes
Jul 1, 2020
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.proto
Outdated
Show resolved
Hide resolved
asraa
reviewed
Jul 1, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
This is very nice! Love how easy to understand this is. I have a few minor questions.
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.proto
Outdated
Show resolved
Hide resolved
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.proto
Show resolved
Hide resolved
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.cc
Outdated
Show resolved
Hide resolved
asraa
reviewed
Jul 1, 2020
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
asraa
reviewed
Jul 6, 2020
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
akonradi
suggested changes
Jul 7, 2020
test/extensions/filters/listener/original_dst/original_dst_fuzz_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Yan <arthuryan@google.com>
asraa
approved these changes
Jul 7, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks Arthur! Excited to ship this and iterate on more fuzzers :)
(and particularly excited about re-using the super speedy socket!)
jwendell
pushed a commit
to istio/envoy
that referenced
this pull request
Jul 21, 2020
* Revert "test: shard http2_integration_test (envoyproxy#11939)" This reverts commit 2026ec2. * Revert "fuzz: added fuzz test for listener filter original_dst (envoyproxy#11847)" This reverts commit 673cab8. * Revert "docs: updating release instructions (envoyproxy#11938)" This reverts commit 09b96a5. * Revert "test: remove superfluous test dependencies (envoyproxy#11912)" This reverts commit 5e9fb8a. * Revert "dynamic_forward_proxy: cleanup integration test (envoyproxy#11891)" This reverts commit 11a4667. * Revert "preliminary PR to Porting Envoy to C++17 (envoyproxy#11840)" This reverts commit 9ad964d. * Revert "connection: Do not reset delayed closed timer if doWrite consumes 0 bytes from the output buffer. (envoyproxy#11833)" This reverts commit 5960533. * Revert "threadlocal: avoiding a dynamic cast in opt builds (envoyproxy#11900)" This reverts commit 363b104. * Revert "release: kicking off 1.16.0 (envoyproxy#11930)" This reverts commit ef74d8f. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
) Commit Message: Added fuzz test for listener filter original_dst Created original_dst_corpus and populated with testcases (different protocol schemes) Created original_dst_fuzz_test.cc and original_dst_fuzz_test.proto, updated BUILD increased function and line coverage of original_dst.cc to 100%. fuzzer routes correctly through getOriginalDst() and addressFromSockAddr(), covers all valid cases / lines. Signed-off-by: Arthur Yan <arthuryan@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Yan arthuryan@google.com
Commit Message: Added fuzz test for listener filter original_dst
Additional Description:
Created original_dst_corpus and populated with testcases (different protocol schemes)
Created original_dst_fuzz_test.cc and original_dst_fuzz_test.proto, updated BUILD
Risk Level: Low
Testing: ran fuzzer, increased function and line coverage of original_dst.cc to 100%. fuzzer routes correctly through getOriginalDst() and addressFromSockAddr(), covers all valid cases / lines.
Docs Changes: N/A
Release Notes: N/A
/cc @akonradi
/cc @asraa