Skip to content

fuzz: fix oss crash on http utility function #11687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asraa merged 6 commits into from
Jun 24, 2020
Merged

fuzz: fix oss crash on http utility function #11687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce8c1c9
fix with set
Jun 22, 2020
2e1cba5
cast to unsigned
Jun 22, 2020
4f4bb0e
style fix
Jun 22, 2020
6f5f875
catch exception instead of returning early
Jun 22, 2020
2d0e3d5
check for specific exceptions and fix malformed proto input
Jun 23, 2020
b39e08d
use absl::string_view and starts/endsWith instead of std::string
Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...mon/http/utility_corpus/clusterfuzz-testcase-minimized-utility_fuzz_test-5091558495092736
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions test/common/http/utility_corpus/valid
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 22 additions & 1 deletion test/common/http/utility_fuzz_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,28 @@ DEFINE_PROTO_FUZZER(const test::common::http::UtilityTestCase& input) {
}
case test::common::http::UtilityTestCase::kInitializeAndValidate: {
const auto& options = input.initialize_and_validate();
Http2::Utility::initializeAndValidateOptions(options);
try {
Http2::Utility::initializeAndValidateOptions(options);
} catch (EnvoyException& e) {
absl::string_view msg = e.what();
// initializeAndValidateOptions throws exceptions for 4 different reasons due to malformed
// settings, so check for them and allow any other exceptions through
if (absl::StartsWith(
msg, "server push is not supported by Envoy and can not be enabled via a SETTINGS "
"parameter.") ||
absl::StartsWith(
msg, "the \"allow_connect\" SETTINGS parameter must only be configured through the "
"named field") ||
absl::StartsWith(
msg, "inconsistent HTTP/2 custom SETTINGS parameter(s) detected; identifiers =") ||
absl::EndsWith(
msg, "HTTP/2 SETTINGS parameter(s) can not be configured through both named and "
"custom parameters")) {
ENVOY_LOG_MISC(trace, "Caught exception {} in initializeAndValidateOptions test", e.what());
} else {
throw EnvoyException(e.what());
}
}
break;
}

Expand Down