fuzz: fix oss crash on http utility function#11687
Merged
asraa merged 6 commits intoenvoyproxy:masterfrom Jun 24, 2020
Merged
Conversation
added 3 commits
June 22, 2020 15:54
Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: Sam Flattery <samflattery@google.com>
samflattery
force-pushed
the
utility_crash
branch
from
3ad9a7a to
4f4bb0e
Compare
Contributor
Author
|
/cc @asraa |
asraa
suggested changes
Jun 22, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks Sam!
Looks like the docstring does warn that collisions results in failures, so thanks for checking on that!
envoy/api/envoy/config/core/v3/protocol.proto
Line 306 in e5ccf1a
Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: Sam Flattery <samflattery@google.com>
AndresGuedez
previously approved these changes
Jun 23, 2020
Contributor
AndresGuedez
left a comment
AndresGuedez
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Signed-off-by: Sam Flattery <samflattery@google.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Commit Message: Fix crash on initializeAndValidateOptions fuzz test the crash occurred because validateCustomSettingsParameters does not allow duplicate custom settings identifiers and the fuzzer fed it an input that had duplicates. fixed by catching expected exceptions from duplicate custom settings identifiers. Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23616 Signed-off-by: Sam Flattery <samflattery@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Commit Message: Fix crash on initializeAndValidateOptions fuzz test the crash occurred because validateCustomSettingsParameters does not allow duplicate custom settings identifiers and the fuzzer fed it an input that had duplicates. fixed by catching expected exceptions from duplicate custom settings identifiers. Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23616 Signed-off-by: Sam Flattery <samflattery@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Fix crash on
initializeAndValidateOptionsfuzz testAdditional Description:
validateCustomSettingsParametersdoes not allow duplicate custom settings identifiers and the fuzzer fed it an input that had duplicatesRisk Level: Low
Testing: Passes the existing utility test corpora and new regression entry added
Docs Changes: N/A
Release Notes: N/A
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23616