admission control: Filter implementation with no-op controller#11414
Merged
mattklein123 merged 120 commits intoenvoyproxy:masterfrom Jun 17, 2020
Merged
admission control: Filter implementation with no-op controller#11414mattklein123 merged 120 commits intoenvoyproxy:masterfrom
mattklein123 merged 120 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123
previously approved these changes
Jun 17, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, looks good to ship and iterate. LMK if you want to add the TODO in this PR or do it in a follow up.
| /** | ||
| * A filter that probabilistically rejects requests based on upstream success-rate. | ||
| */ | ||
| class AdmissionControlFilter : public Http::PassThroughFilter, |
Member
There was a problem hiding this comment.
Do you want to add a TODO in code somewhere about the reset thread? I think you do want to handle that. Feel free to add the TODO in a follow up if you want.
Member
Author
There was a problem hiding this comment.
Went ahead and threw in the comment. Thanks for reminding me.
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123
approved these changes
Jun 17, 2020
florincoras
added a commit
to florincoras/envoy
that referenced
this pull request
Jun 18, 2020
Test added by envoyproxy#11414 uses RequestHeaderMapImpl constructor made private in envoyproxy#11546 Signed-off-by: Florin Coras <fcoras@cisco.com>
lizan
pushed a commit
that referenced
this pull request
Jun 18, 2020
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
…proxy#11414) Signed-off-by: Tony Allen <tony@allen.gg> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
Test added by envoyproxy#11414 uses RequestHeaderMapImpl constructor made private in envoyproxy#11546 Signed-off-by: Florin Coras <fcoras@cisco.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
…proxy#11414) Signed-off-by: Tony Allen <tony@allen.gg>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Test added by envoyproxy#11414 uses RequestHeaderMapImpl constructor made private in envoyproxy#11546 Signed-off-by: Florin Coras <fcoras@cisco.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
…proxy#11414) Signed-off-by: Tony Allen <tony@allen.gg> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Test added by envoyproxy#11414 uses RequestHeaderMapImpl constructor made private in envoyproxy#11546 Signed-off-by: Florin Coras <fcoras@cisco.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First patch in a series implementing #9658. The basic filter logic, HTTP/gRPC code evaluation, and configuration are implemented. Still requires the actual admission control logic implementation and documentation.
This is a break-up of PR #10985.
Risk Level: Low (new filter)
Testing: Unit test
Docs Changes: Only proto documenation implemented.
Release Notes: n/a
Progress toward: #9658