Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan
added a commit
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
pushed a commit
that referenced
this pull request
Jul 9, 2020
…resumes requests on destruction. (#11739) * doc: fix SNI FAQ link (#10227) Signed-off-by: Lizan Zhou <lizan@tetrate.io> * make api pause/resume in pair by returning a RAII obj which resumes requests on destruction Signed-off-by: Xin Zhuang <stevenzzz@google.com> * cancel resume_cds_ on shutdown of clustermanagerImpl Signed-off-by: Xin Zhuang <stevenzzz@google.com> * format errors fix Signed-off-by: Xin Zhuang <stevenzzz@google.com> * move the ABSL_MUST_USE_RESULT attr to the beginning to see if gcc will be happy Signed-off-by: Xin Zhuang <stevenzzz@google.com> * pass by reference type_urls into cleanup in scoped rds Signed-off-by: Xin Zhuang <stevenzzz@google.com> * review fixes per Harvey comments. Signed-off-by: Xin Zhuang <stevenzzz@google.com> * remove unused parameter, weird it wasnt caught previously Signed-off-by: Xin Zhuang <stevenzzz@google.com> * fix-format using clang 10 Signed-off-by: Xin Zhuang <stevenzzz@google.com> Co-authored-by: Lizan Zhou <lizan@tetrate.io>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
…resumes requests on destruction. (envoyproxy#11739) * doc: fix SNI FAQ link (envoyproxy#10227) Signed-off-by: Lizan Zhou <lizan@tetrate.io> * make api pause/resume in pair by returning a RAII obj which resumes requests on destruction Signed-off-by: Xin Zhuang <stevenzzz@google.com> * cancel resume_cds_ on shutdown of clustermanagerImpl Signed-off-by: Xin Zhuang <stevenzzz@google.com> * format errors fix Signed-off-by: Xin Zhuang <stevenzzz@google.com> * move the ABSL_MUST_USE_RESULT attr to the beginning to see if gcc will be happy Signed-off-by: Xin Zhuang <stevenzzz@google.com> * pass by reference type_urls into cleanup in scoped rds Signed-off-by: Xin Zhuang <stevenzzz@google.com> * review fixes per Harvey comments. Signed-off-by: Xin Zhuang <stevenzzz@google.com> * remove unused parameter, weird it wasnt caught previously Signed-off-by: Xin Zhuang <stevenzzz@google.com> * fix-format using clang 10 Signed-off-by: Xin Zhuang <stevenzzz@google.com> Co-authored-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10225
Signed-off-by: Lizan Zhou lizan@tetrate.io