fix: upstream grpc stats on trailers only#10842
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 20, 2020
Merged
fix: upstream grpc stats on trailers only#10842mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
mattklein123
requested changes
Apr 20, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for fixing. One small comment. Thank you!
/wait
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Contributor
Author
|
@mattklein123 fixed 😄 |
ggreenway
reviewed
Apr 20, 2020
penguingao
pushed a commit
to penguingao/envoy
that referenced
this pull request
Apr 22, 2020
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io> Signed-off-by: pengg <pengg@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrik Cyvoct patrik@ptrk.io
Fixes #10748 (comment)
Description: Record upstream grpc stats on trailers only response
Risk Level: Low
Testing: Unit
Docs Changes: none
Release Notes: none
cc @mattklein123 @ggreenway