build: remove explicit PY2/PY3 references.#10664
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Apr 7, 2020
Merged
build: remove explicit PY2/PY3 references.#10664mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Now that we are Python 3 everywhere, remove explicit python_versions. I haven't made this change yet to the Thrift extension, as it has explicit PY2/PY3 overrides that I'm guessing relate to external libs. Risk level: Low (tooling only) Testing: bazel.api Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@zuercher do you know what's needed to move https://github.com/envoyproxy/envoy/blob/master/test/extensions/filters/network/thrift_proxy/driver/BUILD#L19 to Python 3? This is the last straggler in the Python 3 everywhere push. |
Member
|
@htuch I don't remember off the top of my head. I can try to take a look later this week. |
Contributor
|
The Kafka extension specifies PY2. Despite my local tests passing my PR failed again with Kafka and the Jinja update - #10594. I plan on taking the Jinja updates our of this PR. No response from @adamkotwasinski on Twitter or Slack |
Member
|
Merge master to fix CI? /wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are Python 3 everywhere, remove explicit python_versions. I haven't made this change yet
to the Thrift extension, as it has explicit PY2/PY3 overrides that I'm guessing relate to external
libs.
Risk level: Low (tooling only)
Testing: bazel.api
Signed-off-by: Harvey Tuch htuch@google.com