Skip to content

Dependencies: build updates#10594

Closed
moderation wants to merge 8 commits intoenvoyproxy:masterfrom
moderation:master
Closed

Dependencies: build updates#10594
moderation wants to merge 8 commits intoenvoyproxy:masterfrom
moderation:master

Conversation

@moderation
Copy link
Contributor

Description: Updates for build components

  • bazelisk (documentation only)
  • ninja (documentation only)
  • bazel-compilation-database 0.4.3 (release notes)
  • bazel-gazelle v0.20.0 (release notes)
  • bazel-toolchains 2.2.0 (changes)
  • libprotobuf-mutator - no code change - only adding missing SHA
  • jinja-2.11.1 (release notes)
  • kafka filter - change python shebang to be consistent with the rest of the codebase

Risk Level: Low
Testing: bazel --nohome_rc test --config=libc++ //test/...
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michael Payne michael@sooper.org

Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bazel/README.md Outdated

```
sudo wget -O /usr/local/bin/bazel https://github.com/bazelbuild/bazelisk/releases/download/v0.0.8/bazelisk-linux-amd64
sudo wget -O /usr/local/bin/bazel https://github.com/bazelbuild/bazelisk/releases/download/v1.3.0/bazelisk-linux-amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo wget -O /usr/local/bin/bazel https://github.com/bazelbuild/bazelisk/releases/download/v1.3.0/bazelisk-linux-amd64
sudo wget -O /usr/local/bin/bazel https://github.com/bazelbuild/bazelisk/releases/latest/download/bazelisk-linux-amd64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will definitely make this change. Giving up on Jinja as even though tests pass locally the Kafka extension breaks CI.

@stale
Copy link

stale bot commented Apr 15, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 15, 2020
@stale
Copy link

stale bot commented Apr 23, 2020

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants