tracing: use weak references when caching HttpTracers inside HttpTracerManager#10410
Closed
yskopets wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
tracing: use weak references when caching HttpTracers inside HttpTracerManager#10410yskopets wants to merge 1 commit intoenvoyproxy:masterfrom
HttpTracers inside HttpTracerManager#10410yskopets wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
…racerManager` Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io>
Member
|
Putting into waiting until the other PRs are merged. /wait |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: use weak references when caching
HttpTracers insideHttpTracerManagerRisk Level: Medium
Testing: unit tests
Docs Changes: N/A
Release Notes: N/A
Context:
AsyncClientRequestTrackerto keep track of inflight requests and cancel them on destruction #10359 and tracing: Datadog: do cleanup on tracer destruction in order to support dynamic (re-)configuration #10403 (in other words, when all tracing providers support clean up on destruction)