tracing: Datadog: do cleanup on tracer destruction in order to support dynamic (re-)configuration#10403
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Mar 24, 2020
Conversation
yskopets
requested review from
alyssawilk,
dio,
lizan and
mattklein123
as code owners
Member
|
Putting into waiting state until we get the dependent PRs merged. Thank you! /wait |
yskopets
force-pushed
the
feature/do-cleanup-on-datadog-tracer-destruction
branch
from
81c4fa6 to
e0152ea
Compare
…t dynamic (re-)configuration Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io>
yskopets
force-pushed
the
feature/do-cleanup-on-datadog-tracer-destruction
branch
from
e0152ea to
4941e9e
Compare
Member
Author
|
@mattklein123 It is now ready for review. All dependant PRs have been merged. Sorry, I had to rebase instead of doing merge. |
Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io>
Member
Author
|
/retest |
|
🔨 rebuilding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: do cleanup on
datadogtracer destruction in order to support dynamic (re-)configurationRisk Level: Low
Testing: unit tests
Docs Changes: N/A
Release Notes: N/A
Context:
depends on async client: refactorHttp::AsyncClient::Callbacksto pass inHttp::AsyncClient::Request*for correlation between requests and responses #10358 and async client: introduceAsyncClientRequestTrackerto keep track of inflight requests and cancel them on destruction #10359Motivation:
Datadogtracer allows multiple in-flight requests to the collector, we need to keep track of all of them and cancel them if tracer gets removed