stats: clear the stats storage before asserting the symbol table is empty.#10245
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Mar 4, 2020
Merged
stats: clear the stats storage before asserting the symbol table is empty.#10245mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Contributor
Author
|
@mattklein123 this may be a candidate for force-merging as though it's being bitten by one all-tests-in-one-binary issue, it resolves another one,. And I think it's obvious this is coverage neutral. FWIW you can argue I could rename the testing-peer class to the fact that it's now really a context, or that could be a follow-up. Up to you. |
mattklein123
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: fixes a coverage-test issue related to keeping whether we use real/fake symbol tables in a static that is not cleared at the end of tests. Also reset that at the end of tests via RAII.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a