set enablePlatformCertificateValidation to false on iOS by default#2663
Merged
RyanTheOptimist merged 1 commit intoenvoyproxy:mainfrom Nov 7, 2022
Merged
Conversation
Signed-off-by: Ryan Hamilton <rch@google.com>
Contributor
Author
|
/assign @jpsim |
jpsim
approved these changes
Nov 7, 2022
Contributor
jpsim
left a comment
jpsim
left a comment
There was a problem hiding this comment.
+1 although hopefully tests fail with this and need to be updated to reflect the new defaults
jpsim
added a commit
that referenced
this pull request
Nov 14, 2022
…builder-function * origin/main: ci: hopefully fixing bes timeout failures (#2666) Update Envoy (#2660) bazel: update rules_jvm_external to 4.5 (#2665) Remove note about DWARF patch being required (#2645) Bump Lyft Support Rotation (#2661) build: remove alwayslink set enablePlatformCertificateValidation to false on iOS by default (#2663) bump Envoy dep (#2659) Implement an iOS platform certificate verifier. (#2638) Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Hamilton rch@google.com
Was set to true inadvertently in #2638.