Remove note about DWARF patch being required

[RyanTheOptimist]

As per #1274 (comment), this patch is no longer required.

Signed-off-by: Ryan Hamilton rch@google.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

[jpsim]

Envoy's linux build config still passes --features=per_object_debug_info: https://github.com/envoyproxy/envoy/blob/66e5e6f9ee201a4ebdb7c33cd83d30a72ca357d4/.bazelrc#L44

And that passes -gsplit-dwarf: https://github.com/bazelbuild/bazel/blob/19b8d24531fb728701a85ec050361d434600b5d2/tools/cpp/unix_cc_toolchain_config.bzl#L406

And bloaty still doesn't support that. So from what I can tell, this is still needed?

[RyanTheOptimist]

Envoy's linux build config still passes --features=per_object_debug_info: https://github.com/envoyproxy/envoy/blob/66e5e6f9ee201a4ebdb7c33cd83d30a72ca357d4/.bazelrc#L44

And that passes -gsplit-dwarf: https://github.com/bazelbuild/bazel/blob/19b8d24531fb728701a85ec050361d434600b5d2/tools/cpp/unix_cc_toolchain_config.bzl#L406

And bloaty still doesn't support that. So from what I can tell, this is still needed?

Hm! That's curious. Both @alyssawilk and I were able to follow the instructions on that page without applying the patch and got bloaty output successfully. As a result, it seemed like it wasn't required.

On the other hand, @abeyad did have some issue getting bloaty to work. Ali, if you apply the patch, are you able to get bloaty to work?

[abeyad]

Even applying that patch, I still get:

bloaty: Don't know how to parse DWARF form: 39

Note that the patch doesn't seem to be fully relevant anymore: I could comment out the lines in .bazelrc as JP mentioned, but in bazel/envoy_internal.bzl, the -gsplit-dwarf option no longer exists in that file, so there is nothing to patch there.

Regardless, applying what's left of the patch still gives me the error above.

[RyanTheOptimist]

@jpsim WDYT?

[abeyad]

I forgot to follow up here, but after running bazel build with --config=release-android, the DWARF problem went away, so I don't think we need the patch, and it's not fully accurate now since some of the patch doesn't apply anymore.

[RyanTheOptimist]

@jpsim friendly ping

[jpsim]

I'm ok removing this if it's not helpful.