Skip to content

Squelch two JNI build warnings#2426

Merged
RyanTheOptimist merged 1 commit intoenvoyproxy:mainfrom
RyanTheOptimist:Warnings
Jul 15, 2022
Merged

Squelch two JNI build warnings#2426
RyanTheOptimist merged 1 commit intoenvoyproxy:mainfrom
RyanTheOptimist:Warnings

Conversation

@RyanTheOptimist
Copy link
Contributor

I currently see 3 build warnings when I try to build Envoy Mobile.

INFO: From Compiling library/common/jni/jni_interface.cc:
library/common/jni/jni_interface.cc:1195:13: warning: unused function 'jvm_verify_x509_cert_chain' [-Wunused-function]
static void jvm_verify_x509_cert_chain(const std::vector<std::string>& cert_chain,
            ^
1 warning generated.
INFO: From Compiling library/common/jni/jni_utility.cc:
In file included from library/common/jni/jni_utility.cc:6:
In file included from external/envoy/source/common/common/assert.h:5:
In file included from external/envoy/source/common/common/logger.h:13:
external/envoy/source/common/common/fine_grain_logger.h:20:1: warning: inline variables are a C++17 extension [-Wc++17-extensions]
inline const char* kDefaultFineGrainLogFormat = "[%Y-%m-%d %T.%e][%t][%l] [%g:%#] %v";
^
library/common/jni/jni_utility.cc:28:32: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
    static char* thread_name = "EnvoyMain";
                               ^
2 warnings generated.

This PR squelches the two of them that are in Envoy Mobile code.

Signed-off-by: Ryan Hamilton rch@google.com

Risk Level: Low
Testing: Builds
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Ryan Hamilton <rch@google.com>
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RyanTheOptimist RyanTheOptimist merged commit 36e0eda into envoyproxy:main Jul 15, 2022
jpsim added a commit that referenced this pull request Jul 18, 2022
* main:
  tools: fix source mapping (#2429)
  Update Envoy (#2427)
  tools: add arm64 debug run configuration (#2424)
  Revert "docs: use sphinx githubpages extension (#2418)" (#2425)
  Remove Tulsi configuration & docs (#2421)
  Fix isCleartextTrafficPermitted (#2420)
  Squelch two JNI build warnings (#2426)
  dns: allow using the `getaddrinfo`-based system DNS resolver (#2419)
  docs: use sphinx githubpages extension (#2418)
  Update Envoy (#2417)
  Remove rules_cc uses
  Bump Lyft Support Rotation (#2414)
  iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415)
  Update Envoy (#2413)
  engine: remove outdated comment about `registerFactories()` (#2412)
  api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410)

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants