Fix isCleartextTrafficPermitted#2420
Merged
RyanTheOptimist merged 1 commit intoenvoyproxy:mainfrom Jul 18, 2022
Merged
Conversation
Contributor
Author
|
/assign @alyssawilk |
alyssawilk
previously approved these changes
Jul 14, 2022
Signed-off-by: Ryan Hamilton <rch@google.com>
RyanTheOptimist
force-pushed
the
isCleartextTrafficPermitted
branch
from
22e7fcb to
7988d15
Compare
alyssawilk
approved these changes
Jul 18, 2022
jpsim
added a commit
that referenced
this pull request
Jul 18, 2022
* main: tools: fix source mapping (#2429) Update Envoy (#2427) tools: add arm64 debug run configuration (#2424) Revert "docs: use sphinx githubpages extension (#2418)" (#2425) Remove Tulsi configuration & docs (#2421) Fix isCleartextTrafficPermitted (#2420) Squelch two JNI build warnings (#2426) dns: allow using the `getaddrinfo`-based system DNS resolver (#2419) docs: use sphinx githubpages extension (#2418) Update Envoy (#2417) Remove rules_cc uses Bump Lyft Support Rotation (#2414) iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415) Update Envoy (#2413) engine: remove outdated comment about `registerFactories()` (#2412) api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410) Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix isCleartextTrafficPermitted by finding a static method (instead of an object method) and calling
the static method of the AndroidNetworkLibrary class instead of calling the instance method on a string.
Testing: Needs tests :)]