Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ repos:
exclude: 'experimental/swift/QUICStreamTest.swift'
- id: mixed-line-ending
- repo: https://github.com/codespell-project/codespell
rev: v1.16.0
rev: v2.1.0
hooks:
- id: codespell
args: [-L=uint, -L=keyserver]
args: [-L=uint, '-L=keyserver,inout']
2 changes: 1 addition & 1 deletion docs/root/api/stats.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ The count argument of ``increment`` is defaulted with a value of ``1``.
// Swift
counter.increment(count: 5)

A ``Counter`` can be incremented with custom tags. To be concise, this doc shows examples of attching custom tagging for ``Counter`` on increment. Similar APIs are available for all metrics types to attach tags on metrics reporting.
A ``Counter`` can be incremented with custom tags. To be concise, this doc shows examples of attaching custom tagging for ``Counter`` on increment. Similar APIs are available for all metrics types to attach tags on metrics reporting.

**Example**::

Expand Down
1 change: 1 addition & 0 deletions docs/root/intro/version_history.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Features:
- android: create simple persistent SharedPreferencesStore (:issue: `#2319 <2319>`)
- iOS: A documentation archive is now included in the GitHub release artifact (:issue: `#2335 <2335>`)
- api: improved C++ APIs compatibility with Java / Kotlin / Swift (:issue `#2362 <2362>`)
- ci: bump codespell version to v2.1.0 (:issue `#2406 <2406>`)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually only include user-facing changes in the changelog.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed


0.4.6 (April 26, 2022)
========================
Expand Down
7 changes: 4 additions & 3 deletions library/java/org/chromium/net/CronetEngine.java
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,10 @@ public Builder addPublicKeyPins(String hostName, Set<byte[]> pinsSha256,
* for local trust anchors is highly discouraged since it may prohibit the app from
* communicating with the pinned hosts. E.g., a user may want to send all traffic through an SSL
* enabled proxy by changing the device proxy settings and adding the proxy certificate to the
* list of local trust anchor. Disabling the bypass will most likly prevent the app from sending
* any traffic to the pinned hosts. For more information see 'How does key pinning interact with
* local proxies and filters?' at https://www.chromium.org/Home/chromium-security/security-faq
* list of local trust anchor. Disabling the bypass will most likely prevent the app from
* sending any traffic to the pinned hosts. For more information see 'How does key pinning
* interact with local proxies and filters?' at
* https://www.chromium.org/Home/chromium-security/security-faq
*
* @param value {@code true} to enable the bypass, {@code false} to disable.
* @return the builder to facilitate chaining.
Expand Down
2 changes: 1 addition & 1 deletion test/python/unit/test_pre_build_engine.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This module can't be tested normally
# becuse it needs the Engine not to exist in the process
# because it needs the Engine not to exist in the process
# so each of the tests here are marked to be run
# only in a particular instance of the test runner
# and targets are specified in //library/python/...
Expand Down