Merged
Conversation
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
changed the title
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
changed the title
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
reviewed
Jul 5, 2022
docs/root/intro/version_history.rst
Outdated
| - android: create simple persistent SharedPreferencesStore (:issue: `#2319 <2319>`) | ||
| - iOS: A documentation archive is now included in the GitHub release artifact (:issue: `#2335 <2335>`) | ||
| - api: improved C++ APIs compatibility with Java / Kotlin / Swift (:issue `#2362 <2362>`) | ||
| - ci: bump codespell version to v2.1.0 (:issue `#2406 <2406>`) |
Contributor
There was a problem hiding this comment.
We usually only include user-facing changes in the changelog.
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Update codespell to v2.1.0 due to an issue that surfaced in #2400 :
/usr/local/Cellar/python@3.10/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/codecs.py:905: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used file = builtins.open(filename, mode, buffering). According to codespell-project/codespell#1331 the update is what fixes it.Risk Level: Low, linting change only
Testing: N/A
Docs Changes: N/A
Release Notes: Done
Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com