connectivity_manager: rename/refactor from Network::Configurator#2401
Merged
connectivity_manager: rename/refactor from Network::Configurator#2401
Conversation
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Contributor
|
/retest |
Augustyniak
reviewed
Jul 1, 2022
Contributor
Augustyniak
left a comment
Augustyniak
left a comment
There was a problem hiding this comment.
left one specific comment plus an overall comment: Not sure whether we need network prefix in variables/methods that works with Network::ConnectivityManager - "connectivity" part of the name itself seems to be implying "network" but it's really just me nit picking. Consider dropping it.
library/common/extensions/retry/options/network_configuration/predicate.cc
Show resolved
Hide resolved
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Augustyniak
approved these changes
Jul 1, 2022
jpsim
added a commit
that referenced
this pull request
Jul 5, 2022
* origin/main: Update Envoy (#2403) connectivity_manager: rename/refactor from Network::Configurator (#2401) test: fixing up build targets to use the extension registry (#2397) test: Adds an integration test for SDS (#2395) iOS: add `forceIPv6(...)` builder option (#2396) api: make iOS Headers and HeadersBuilder case-insensitive (#2383) Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This is intended to better capture the role and responsibilities of this class in Envoy Mobile. It still "configures connections", but more generally, it holds library/device connectivity state and provides mechanisms to leverage it.
Risk Level: Low
Testing: Updated tests.
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Mike Schore mike.schore@gmail.com