api: make iOS Headers and HeadersBuilder case-insensitive by Augustyniak · Pull Request #2383 · envoyproxy/envoy-mobile

Augustyniak · 2022-06-23T14:04:55Z

Description: Make the lookup of headers in HeadersBuilder and Headers case-insensitive and preserve the original casing of headers. Implemented on iOS only. Android side-changes are going to be implemented in a follow up PR. GH issue: #2390.
Risk Level: Low
Testing: Unit Tests
Docs Changes: Updated
Release Notes: Updated

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak · 2022-06-25T01:30:02Z

@goaway This is now ready for review. I incorporate your offline feedback with regard to making Headers case-insensitive too.

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak · 2022-06-25T01:54:40Z

I would expect DrString to catch the issue that I found manually in 6389322. @jpsim any idea as to why this issue wasn't caught?

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Co-authored-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com>

Augustyniak · 2022-06-28T17:19:47Z

I'm wondering if the internal APIs that currently take header dictionaries should be updated to take a Headers instance instead.

Created an issue to track this #2394.

Also, we should consider adding subscripting support to Headers for more ergonomic lookups.

Created an issue to track this #2393

Co-authored-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com>

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

jpsim

🙌

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

goaway · 2022-06-28T20:03:33Z

examples/objective-c/hello_world/ViewController.m


    NSMutableString *headerMessage = [NSMutableString new];
-    for (NSString *name in headers.allHeaders) {
+    for (NSString *name in headers.caseSensitiveHeaders()) {


I like this rename. 👍

goaway

I like this solution. Nice work @Augustyniak.

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

* origin/main: Update Envoy (#2403) connectivity_manager: rename/refactor from Network::Configurator (#2401) test: fixing up build targets to use the extension registry (#2397) test: Adds an integration test for SDS (#2395) iOS: add `forceIPv6(...)` builder option (#2396) api: make iOS Headers and HeadersBuilder case-insensitive (#2383) Signed-off-by: JP Simard <jp@jpsim.com>

Description: An Android change that mimics iOS changes from #2383. Make the lookup of headers in HeadersBuilder and Headers case-insensitive and preserve the original casing of headers. Risk Level: Low Testing: Unit Docs Changes: Done Release Notes: Done Fixes: #2390 Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Description: An Android change that mimics iOS changes from envoyproxy/envoy-mobile#2383. Make the lookup of headers in HeadersBuilder and Headers case-insensitive and preserve the original casing of headers. Risk Level: Low Testing: Unit Docs Changes: Done Release Notes: Done Fixes: envoyproxy/envoy-mobile#2390 Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>

Augustyniak added 2 commits June 23, 2022 10:06

use insensitive key

8ffc556

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Make HeadersBuilder case insensitive

c3c9015

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak force-pushed the make-headers-builder-case-insensitive branch from 59cf05f to c3c9015 Compare June 23, 2022 14:06

Augustyniak added 2 commits June 23, 2022 10:07

remove unnecessary call

8137392

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Update code

15f722b

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak force-pushed the make-headers-builder-case-insensitive branch from ec84cea to 15f722b Compare June 23, 2022 14:57

Augustyniak added 3 commits June 23, 2022 11:21

Fix formatting

3576622

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

update version history

f7538f2

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Lint fixes

516a1fc

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak force-pushed the make-headers-builder-case-insensitive branch from f371032 to 516a1fc Compare June 23, 2022 15:21

Augustyniak added 2 commits June 23, 2022 11:22

erge branch 'main' into make-headers-builder-case-insensitive

2ff4fb6

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

add doc

42897f2

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak force-pushed the make-headers-builder-case-insensitive branch from 6746393 to 42897f2 Compare June 23, 2022 15:24

Augustyniak marked this pull request as ready for review June 23, 2022 15:40

Augustyniak requested a review from goaway June 23, 2022 15:41

Augustyniak changed the title ~~Make headers builder case insensitive~~ api: make headers builder case insensitive Jun 23, 2022

Augustyniak changed the title ~~api: make headers builder case insensitive~~ api: make HeadersBuilder case insensitive Jun 23, 2022

Augustyniak changed the title ~~api: make HeadersBuilder case insensitive~~ api: make HeadersBuilder case-insensitive Jun 23, 2022

Augustyniak added 6 commits June 23, 2022 11:43

fix casing

0e328a0

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

fix typo

8430f4f

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Improve version history

86ce3fc

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Make Headers case-insensitive too

37c6e5c

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

lint fixes

35c0536

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

swiftlint fix

1fd9938

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak changed the title ~~api: make HeadersBuilder case-insensitive~~ api: make Headers and HeadersBuilder case-insensitive Jun 25, 2022

Augustyniak requested a review from jpsim June 25, 2022 01:29

doc string fix

6389322

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

remove method

3ac922c

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak added 3 commits June 28, 2022 13:13

Update library/swift/HeadersBuilder.swift

a80ef6a

Co-authored-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com>

Update library/swift/HeadersContainer.swift

1a4d915

Co-authored-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com>

Update library/swift/HeadersContainer.swift

2a5085a

Co-authored-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com>

Augustyniak and others added 2 commits June 28, 2022 13:20

Update library/swift/HeadersBuilder.swift

b9d1dd9

Co-authored-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com>

update version history

75a586d

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

jpsim previously approved these changes Jun 28, 2022

View reviewed changes

change used method

7295362

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak dismissed jpsim’s stale review via 7295362 June 28, 2022 18:37

Augustyniak added 3 commits June 28, 2022 14:50

update example app

723c76f

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

update example app

079a01a

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

update example app

62885af

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

jpsim previously approved these changes Jun 28, 2022

View reviewed changes

update example apps

702bc24

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak dismissed jpsim’s stale review via 702bc24 June 28, 2022 19:53

Augustyniak added 2 commits June 28, 2022 15:57

update example apps

d3bd1ea

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

update example apps

d45fa9f

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

goaway reviewed Jun 28, 2022

View reviewed changes

goaway previously approved these changes Jun 28, 2022

View reviewed changes

update example apps

42b38bf

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>

Augustyniak dismissed goaway’s stale review via 42b38bf June 28, 2022 20:21

jpsim approved these changes Jun 28, 2022

View reviewed changes

Augustyniak enabled auto-merge (squash) June 28, 2022 20:29

Augustyniak merged commit 45ee2c3 into main Jun 28, 2022

Augustyniak deleted the make-headers-builder-case-insensitive branch June 28, 2022 20:42

Augustyniak mentioned this pull request Jul 5, 2022

api: make Headers and HeadersBuilder case-insensitive #2400

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api: make iOS Headers and HeadersBuilder case-insensitive#2383

api: make iOS Headers and HeadersBuilder case-insensitive#2383
Augustyniak merged 39 commits intomainfrom
make-headers-builder-case-insensitive

Augustyniak commented Jun 23, 2022 •

edited

Loading

Uh oh!

Augustyniak commented Jun 25, 2022

Uh oh!

Augustyniak commented Jun 25, 2022 •

edited

Loading

Uh oh!

Augustyniak commented Jun 28, 2022

Uh oh!

jpsim left a comment

Uh oh!

goaway Jun 28, 2022

Uh oh!

goaway left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Augustyniak commented Jun 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Augustyniak commented Jun 25, 2022

Uh oh!

Augustyniak commented Jun 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Augustyniak commented Jun 28, 2022

Uh oh!

jpsim left a comment

Choose a reason for hiding this comment

Uh oh!

goaway Jun 28, 2022

Choose a reason for hiding this comment

Uh oh!

goaway left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Augustyniak commented Jun 23, 2022 •

edited

Loading

Augustyniak commented Jun 25, 2022 •

edited

Loading