tests: Adds an RTDS integration test for Envoy Mobile#2328
Merged
RyanTheOptimist merged 4 commits intoenvoyproxy:mainfrom Jun 3, 2022
Merged
tests: Adds an RTDS integration test for Envoy Mobile#2328RyanTheOptimist merged 4 commits intoenvoyproxy:mainfrom
RyanTheOptimist merged 4 commits intoenvoyproxy:mainfrom
Conversation
This test does a simple verification that the RTDS protocol within the xDS family is working correctly. A subsequent PR will improve upon the test coverage. As part of this change, the common parts of running a Envoy Mobile client integration test were refactored out into a new BaseClientIntegrationTest class. Both ClientIntegrationTest and RtdsIntegrationTest inherit from BaseClientIntegrationTest. NB: the parameterized test currently fails when using IPv6. This will be debugged and fixed in a subsequent PR. Signed-off-by: Ali Beyad <abeyad@google.com>
Contributor
Author
|
cc @alyssawilk since I can't seem to assign reviewers through the UI |
abeyad
changed the title
Contributor
Author
|
/retest |
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com>
RyanTheOptimist
previously approved these changes
Jun 1, 2022
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
This looks awesome. Other than one trivial nit, it LGTM.
Signed-off-by: Ali Beyad <abeyad@google.com>
Contributor
Author
Thanks for the review Ryan! |
Contributor
Author
|
/retest |
RyanTheOptimist
approved these changes
Jun 2, 2022
Contributor
|
/assign @goaway for a non-Google take |
goaway
approved these changes
Jun 3, 2022
Contributor
goaway
left a comment
goaway
left a comment
There was a problem hiding this comment.
Looks good to me - nice cleanup of the tests. Thanks!
Contributor
Author
Thanks for the review Mike! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test does a simple verification that the RTDS protocol within the
xDS family is working correctly. A subsequent PR will improve upon the
test coverage.
As part of this change, the common parts of running a Envoy Mobile
client integration test were refactored out into a new
BaseClientIntegrationTest class. Both ClientIntegrationTest and
RtdsIntegrationTest inherit from BaseClientIntegrationTest.
Signed-off-by: Ali Beyad abeyad@google.com
Risk Level: Low
Testing: Test only PR
Docs Changes: N/A
Release Notes: N/A