bazel: Include debug info in Android release binary#2188
Merged
Augustyniak merged 1 commit intomainfrom Apr 23, 2022
Merged
Conversation
Contributor
Author
|
this is increasing the size of objdump files 4x - from around 250MB to around 1GB. |
keith
reviewed
Apr 22, 2022
|
|
||
| # Exclude debug info from the release binary since it makes it too large to fit | ||
| # into a zip file. This shouldn't affect crash reports. | ||
| build:release-common --define=no_debug_info=1 |
Member
There was a problem hiding this comment.
need to change to use for ios but not both instead, because the download size is an issue otherwise
Contributor
Author
There was a problem hiding this comment.
OK, that makes sense
keith
previously approved these changes
Apr 22, 2022
Contributor
|
FYI we won't be able to deploy this to our apps until we merge #2186, or a different fix for that SIGABRT crash. |
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
force-pushed
the
include-release-info
branch
from
28052ee to
81ee7f5
Compare
Contributor
Author
|
@keith mind re-approving? I needed to fix some linter issues and force push to sign-off on my changes. |
keith
approved these changes
Apr 22, 2022
Augustyniak
changed the title
Augustyniak
added a commit
that referenced
this pull request
Apr 26, 2022
Description: Include debug info in the Android release binary. This allows us to have an objdump file with all of the relevant symbols. The change is needed as we moved from symbol mapping table files to symbol mapping files in f955257 Risk Level: low, tooling only Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com
Augustyniak
added a commit
that referenced
this pull request
Apr 26, 2022
This reverts commit 485f427.
Augustyniak
added a commit
that referenced
this pull request
Apr 26, 2022
This reverts commit 485f427. Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
added a commit
that referenced
this pull request
Apr 26, 2022
This reverts commit 412ed6f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Include debug info in the Android release binary. This allows us to have an objdump file with all of the relevant symbols. The change is needed as we moved from symbol mapping table files to symbol mapping files in f955257
Risk Level: low, tooling only
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com