Revert "h3/quic: add experimental option to the Android/JVM EngineBuilder (#2163)"#2186
Merged
Revert "h3/quic: add experimental option to the Android/JVM EngineBuilder (#2163)"#2186
Conversation
jpsim
force-pushed
the
revert-2163-aw-ms/h3-config
branch
from
21b02f3 to
910ab00
Compare
jpsim
commented
Apr 22, 2022
Comment on lines
-406
to
-413
| - name: base_h3 | ||
| connect_timeout: *connect_timeout | ||
| lb_policy: CLUSTER_PROVIDED | ||
| cluster_type: *base_cluster_type | ||
| transport_socket: *base_h3_socket | ||
| upstream_connection_options: *upstream_opts | ||
| circuit_breakers: *circuit_breakers_settings | ||
| typed_extension_protocol_options: *h3_protocol_options |
Contributor
Author
There was a problem hiding this comment.
Removing just these lines avoids the crashes.
Augustyniak
approved these changes
Apr 22, 2022
Contributor
Author
|
It's unclear that this is a problem in Envoy Mobile or our integration at Lyft, but to be safe we'll revert as we investigate. |
goaway
added a commit
that referenced
this pull request
Apr 22, 2022
…ngineBuilder (#2163)" (#2186)" (#2190) Description: This reverts commit b08883b. We were able to confirm the crash we saw with our integration was specific to our integration and not to the public implementation. Risk Level: Low Testing: Manual & CI Signed-off-by: Mike Schore <mike.schore@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 256fe5f.
This was causing hangs/crashes in our Lyft apps so I'm reverting this while I continue to investigate.
Here's the crash backtrace I'm seeing on iOS (not very helpful unfortunately):