Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios: Update examples to display errors with a red background #168

Closed
rebello95 opened this issue Jun 22, 2019 · 1 comment · Fixed by #192
Closed

ios: Update examples to display errors with a red background #168

rebello95 opened this issue Jun 22, 2019 · 1 comment · Fixed by #192
Assignees
@rebello95
Labels
help wanted platform/ios Issues related to iOS
Milestone
v0.2 "Primo"

Comments

@rebello95
Copy link
Contributor

Update the Swift and Objective-C demos to follow the UI logic implemented by #166.

// @buildbreaker
@rebello95 rebello95 added platform/ios Issues related to iOS demo labels Jun 22, 2019
@rebello95 rebello95 added this to the v0.2 "Primo" milestone Jun 22, 2019
@rebello95 rebello95 self-assigned this Jun 22, 2019
@rebello95 rebello95 mentioned this issue Jun 27, 2019
Merged
@rebello95
Copy link
Contributor Author

#192

rebello95 added a commit that referenced this issue Jun 27, 2019
@rebello95
ios: update demos to display errors (#192)
3fd0f33 
Update the Swift and Objective-C demos to follow the UI logic implemented by #166.

Resolves #168.

![Simulator Screen Shot - TestDevice - 2019-06-26 at 18 09 50](https://user-images.githubusercontent.com/2643476/60225905-a890ce00-983d-11e9-93ea-5e2c77829413.png)

Signed-off-by: Michael Rebello <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@rebello95 @jpsim
ios: update demos to display errors (#192)
b887784 
Update the Swift and Objective-C demos to follow the UI logic implemented by envoyproxy/envoy-mobile#166.

Resolves envoyproxy/envoy-mobile#168.

![Simulator Screen Shot - TestDevice - 2019-06-26 at 18 09 50](https://user-images.githubusercontent.com/2643476/60225905-a890ce00-983d-11e9-93ea-5e2c77829413.png)

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@rebello95 @jpsim
ios: update demos to display errors (#192)
7bb7d6c 
Update the Swift and Objective-C demos to follow the UI logic implemented by envoyproxy/envoy-mobile#166.

Resolves envoyproxy/envoy-mobile#168.

![Simulator Screen Shot - TestDevice - 2019-06-26 at 18 09 50](https://user-images.githubusercontent.com/2643476/60225905-a890ce00-983d-11e9-93ea-5e2c77829413.png)

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebello95 rebello95

Labels
help wanted platform/ios Issues related to iOS
Projects
None yet
Milestone
v0.2 "Primo"
Development

Successfully merging a pull request may close this issue.

ios: update demos to display errors envoyproxy/envoy-mobile
1 participant
@rebello95