docs: update custom header docs to match envoy behavior#424
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jan 23, 2018
Merged
docs: update custom header docs to match envoy behavior#424htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Matches changes related to envoyproxy/envoy#2250. Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
kyessenov
reviewed
Jan 19, 2018
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
LGTM modulo unnecessary spaces
Member
Author
|
I added the spaces so that the indenting in all 4 blocks would be the same. |
htuch
approved these changes
Jan 23, 2018
zuercher
added a commit
to envoyproxy/envoy
that referenced
this pull request
Jan 26, 2018
Description: Modifies the parsing of request_headers_to_add and response_headers_to_add to allow multiple variables and to allow static content around variable values. The % delimiters used to denote variables can be escaped by doubling the % sign. Risk Level: Medium Modifies existing features in a way that would make old configurations invalid (if they have % signs in them). Testing: Added unit tests for full coverage of header formatters and parser. Docs Changes: envoyproxy/data-plane-api#424 Release Notes: added Fixes: #2250 Signed-off-by: Stephan Zuercher stephan@turbinelabs.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches changes related to envoyproxy/envoy#2250. Plus some formatting fixes in the header variable definition list.
Signed-off-by: Stephan Zuercher stephan@turbinelabs.io