Skip to content

ci: commits to main pushes image/helm with sha suffix #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathetake merged 3 commits into from
Jul 10, 2025
Merged

ci: commits to main pushes image/helm with sha suffix #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
312978f
replace latest tag with sha
aabchoo Jul 10, 2025
e26d9b5
replace helm version suffix latest with sha
aabchoo Jul 10, 2025
3027ec3
add back latest
aabchoo Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build_and_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,3 +266,5 @@ jobs:
- run: |
make helm-push HELM_CHART_VERSION=v0.0.0-latest
make helm-push HELM_CHART_VERSION=0.0.0-latest
make helm-push HELM_CHART_VERSION=v0.0.0-${{ github.sha }} TAG=${{ github.sha }}
make helm-push HELM_CHART_VERSION=0.0.0-${{ github.sha }} TAG=${{ github.sha }}
10 changes: 8 additions & 2 deletions .github/workflows/docker_build_job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,19 @@ jobs:
password: ${{ secrets.DOCKERHUB_PASSWORD }}

# Push images for the push events, e.g. when a new tag is pushed as well as PR merges.
# * Only use the tag if the event is a tag event, otherwise use "latest".
# * Only use the tag if the event is a tag event, otherwise use the hash.
# * Build for both amd64 and arm64 platforms.
- name: Build and Push Image
run: |
if [[ "$GITHUB_REF" == refs/tags/* ]]; then
TAG="${GITHUB_REF#refs/tags/}"
else
TAG="latest"
TAG="${{ github.sha }}"
fi
make docker-build.${{ matrix.command_name }} CMD_PATH_PREFIX=${{ matrix.cmd_path_prefix }} ENABLE_MULTI_PLATFORMS=true TAG=$TAG DOCKER_BUILD_ARGS="--push"

- name: Build and Push Image Latest
run: |
if [[ "$GITHUB_REF" != refs/tags/* ]]; then
make docker-push.${{ matrix.command_name }} CMD_PATH_PREFIX=${{ matrix.cmd_path_prefix }} ENABLE_MULTI_PLATFORMS=true TAG="latest" DOCKER_BUILD_ARGS="--push"
fi
Loading