ci: commits to main pushes image/helm with sha suffix#852
Merged
Conversation
aabchoo
changed the title
Signed-off-by: Aaron Choo <achoo30@bloomberg.net>
aabchoo
force-pushed
the
aaron/replace-latest-tag-with-sha
branch
from
ab05008 to
d998780
Compare
Signed-off-by: Aaron Choo <achoo30@bloomberg.net>
aabchoo
force-pushed
the
aaron/replace-latest-tag-with-sha
branch
from
d998780 to
e26d9b5
Compare
aabchoo
changed the title
mathetake
reviewed
Jul 10, 2025
mathetake
reviewed
Jul 10, 2025
| make helm-push HELM_CHART_VERSION=v0.0.0-latest | ||
| make helm-push HELM_CHART_VERSION=0.0.0-latest | ||
| make helm-push HELM_CHART_VERSION=v0.0.0-${{ github.sha }} | ||
| make helm-push HELM_CHART_VERSION=0.0.0-${{ github.sha }} |
Member
There was a problem hiding this comment.
Also i think to make the helm chart to point to the commit hash tagged containers, you will need to specify TAG=${{ github.sha }}
Suggested change
| make helm-push HELM_CHART_VERSION=0.0.0-${{ github.sha }} | |
| make helm-push HELM_CHART_VERSION=0.0.0-${{ github.sha }} TAG=${{ github.sha }} |
Member
There was a problem hiding this comment.
you can see if this work correctly by passing them to helm-package locally
Contributor
Author
There was a problem hiding this comment.
Ran
helm package manifests/charts/ai-gateway-crds-helm --app-version 7d293fa14a414d048de11f2599442361716137c3 --version 0.0.0-7d293fa14a414d048de11f2599442361716137c3
I see that the appVersion has been updated 7d293fa14a414d048de11f2599442361716137c3
Signed-off-by: Aaron Choo <achoo30@bloomberg.net>
Contributor
Author
|
Added back latest for both images + helm charts. This means we will be building twice for latest + sha images |
aabchoo
changed the title
aabchoo
changed the title
mathetake
added a commit
that referenced
this pull request
Jul 10, 2025
**Description** Follow up on #852 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
alexagriffith
pushed a commit
to sukumargaonkar/ai-gateway
that referenced
this pull request
Jul 11, 2025
**Description** Replacing `latest` suffix for helm charts and docker image. Replacing suffix with commit message. **Related Issues/PRs (if applicable)** envoyproxy#851 --------- Signed-off-by: Aaron Choo <achoo30@bloomberg.net> Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net>
alexagriffith
pushed a commit
to sukumargaonkar/ai-gateway
that referenced
this pull request
Jul 11, 2025
**Description** Follow up on envoyproxy#852 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net>
alexagriffith
added a commit
to sukumargaonkar/ai-gateway
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> use anthropic default const Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> add helper methods Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> add lower bound temp test Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> make new tool helper and add/fix test Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> validate json schema/ helper Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> remove unused var Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> update return Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> add util tests Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> test: refactors testupstream_test setup in e2e (envoyproxy#853) **Description** This refactors some old tech debt during the e2e test setup. Previously, Testupstream werw defined in case-specific yamls across everywhere except that testupstream_test.yaml test case. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> ci: commits to main pushes image/helm with sha suffix (envoyproxy#852) **Description** Replacing `latest` suffix for helm charts and docker image. Replacing suffix with commit message. **Related Issues/PRs (if applicable)** --------- Signed-off-by: Aaron Choo <achoo30@bloomberg.net> ci: fixes docker_build_job.yaml for latest push (envoyproxy#855) **Description** Follow up on envoyproxy#852 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> docs: adds model name virtualization page (envoyproxy#856) **Description** This adds model name virtualization page that describes a cool "modelNameOveride" API and how it can be used for multiple use cases. **Related Issues/PRs (if applicable)** Closes envoyproxy#846 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> test: increase the GCP credential coverage (envoyproxy#858) ci: drops EG v1.4 from e2e target (envoyproxy#859) **Description** Since the next EG v1.5 will be our target version that AIGW v0.3 will be based on, there's no reason to keep it at the moment. This is mainly to unblock the incoming feature patches that will rely on v1.5 feature, such as envoyproxy#823. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> docs: change from Open AI to OpenAI (envoyproxy#866) **Description** This fixes "Open AI" to "OpenAI" in the documentation. Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Update util_test.go Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> Update util_test.go Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net> remove comments Signed-off-by: Alexa Griffith <agriffith50@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replacing
latestsuffix for helm charts and docker image. Replacing suffix with commit message.Related Issues/PRs (if applicable)
#851