Skip to content
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cc0f6a8
feat: implement GCP Gemini request and response translation for OpenA…
sukumargaonkar Jul 2, 2025
cb12d44
refactor: remove unnecessary string manipulation for GCP model prefix
sukumargaonkar Jul 2, 2025
2088925
address pr comments
sukumargaonkar Jul 2, 2025
da5ec61
remove unnecessary nil check
sukumargaonkar Jul 2, 2025
0b2f21f
address PR comments
sukumargaonkar Jul 3, 2025
df58fe8
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar Jul 3, 2025
a10251e
add missing periods to comments
sukumargaonkar Jul 3, 2025
06821c7
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar Jul 7, 2025
03d28bb
add GCP testcase in textWithUpstream
sukumargaonkar Jul 8, 2025
4879b4e
fix local config
sukumargaonkar Jul 8, 2025
ddc602e
fix testcase
sukumargaonkar Jul 8, 2025
806a2f8
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar Jul 8, 2025
5b5419e
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar Jul 8, 2025
13e8926
handle empty gcp response
sukumargaonkar Jul 8, 2025
39656fc
address PR comment
sukumargaonkar Jul 8, 2025
5300537
address PR comment
sukumargaonkar Jul 9, 2025
1febd58
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar Jul 9, 2025
8393b25
fix test case
sukumargaonkar Jul 9, 2025
2fb7051
refactor: rename conversion functions for clarity and consistency
sukumargaonkar Jul 9, 2025
f61c4e7
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar Jul 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/controller/rotators/gcp_oidc_token_rotator.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ type stsTokenGenerator func(

// gcpOIDCTokenRotator implements Rotator interface for GCP access token exchange.
// It handles the complete authentication flow for GCP Workload Identity Federation:
// 1. Obtaining an OIDC token from the configured provider
// 2. Exchanging the OIDC token for a GCP STS token
// 3. Using the STS token to impersonate a GCP service account
// 4. Storing the resulting access token in a Kubernetes secret
// 1. Obtaining an OIDC token from the configured provider.
// 2. Exchanging the OIDC token for a GCP STS token.
// 3. Using the STS token to impersonate a GCP service account.
// 4. Storing the resulting access token in a Kubernetes secret.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert this ?

type gcpOIDCTokenRotator struct {
client client.Client // Kubernetes client for interacting with the cluster.
logger logr.Logger // Logger for recording rotator activities.
Expand Down
Loading