-
Notifications
You must be signed in to change notification settings - Fork 199
feat: implement GCP Gemini request and response translation #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
cc0f6a8
feat: implement GCP Gemini request and response translation for OpenA…
sukumargaonkar cb12d44
refactor: remove unnecessary string manipulation for GCP model prefix
sukumargaonkar 2088925
address pr comments
sukumargaonkar da5ec61
remove unnecessary nil check
sukumargaonkar 0b2f21f
address PR comments
sukumargaonkar df58fe8
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar a10251e
add missing periods to comments
sukumargaonkar 06821c7
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar 03d28bb
add GCP testcase in textWithUpstream
sukumargaonkar 4879b4e
fix local config
sukumargaonkar ddc602e
fix testcase
sukumargaonkar 806a2f8
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar 5b5419e
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar 13e8926
handle empty gcp response
sukumargaonkar 39656fc
address PR comment
sukumargaonkar 5300537
address PR comment
sukumargaonkar 1febd58
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar 8393b25
fix test case
sukumargaonkar 2fb7051
refactor: rename conversion functions for clarity and consistency
sukumargaonkar f61c4e7
Merge remote-tracking branch 'upstream/main' into gcp-basic-requests
sukumargaonkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we prioritize this TODO, i think it is important translation to deliver user error response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plan to do this in the next PR