Skip to content

revert: back to use REPLACE_AND_CONTINUE#814

Merged
mathetake merged 1 commit intoenvoyproxy:mainfrom
yuzisun:revert-body-buffer
Jul 2, 2025
Merged

revert: back to use REPLACE_AND_CONTINUE#814
mathetake merged 1 commit intoenvoyproxy:mainfrom
yuzisun:revert-body-buffer

Conversation

@yuzisun
Copy link
Copy Markdown
Contributor

@yuzisun yuzisun commented Jul 2, 2025

Description
The upstream filter body phase extproc handling can cause envoy to crash and to be cautious we should restrict the usage across ai gateway repo.

This reverts commit 1bed302.

@yuzisun yuzisun requested a review from a team as a code owner July 2, 2025 00:10
@yuzisun yuzisun changed the title Revert "extproc: reverts the use of REPLACE_AND_CONTINUE (#730)" revert: "extproc: reverts the use of REPLACE_AND_CONTINUE (#730)" Jul 2, 2025
@yuzisun yuzisun changed the title revert: "extproc: reverts the use of REPLACE_AND_CONTINUE (#730)" revert: back to use REPLACE_AND_CONTINUE Jul 2, 2025
)"

This reverts commit 1bed302.

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun yuzisun force-pushed the revert-body-buffer branch from 543da61 to bd92b19 Compare July 2, 2025 00:12
@mathetake
Copy link
Copy Markdown
Member

Can you revert the AWS one as well #788

@mathetake
Copy link
Copy Markdown
Member

(Until I find the content length workarounds)

@yuzisun
Copy link
Copy Markdown
Contributor Author

yuzisun commented Jul 2, 2025

Can you revert the AWS one as well #788

done in #815

mathetake pushed a commit that referenced this pull request Jul 2, 2025
**Description**
As we are reverting #814 to
keep using REPLACE_AND_CONTINUE, we need to reverts the commit
92e5202 to avoid the inclusion of
content-length header in the signature with chunked encoding.

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@mathetake mathetake merged commit 5b55865 into envoyproxy:main Jul 2, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants