extproc: reverts the use of REPLACE_AND_CONTINUE#730
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
wengyao04
reviewed
Jun 27, 2025
Contributor
wengyao04
left a comment
wengyao04
left a comment
There was a problem hiding this comment.
lgtm, but some tests fail
Member
Author
|
oh yeah wierd... |
Member
Author
|
ok passing |
Contributor
|
Do you think we can revert this change back ? TO allow aws sign with content-lengh ? |
yuzisun
added a commit
to yuzisun/ai-gateway
that referenced
this pull request
Jul 2, 2025
)" This reverts commit 1bed302.
yuzisun
added a commit
to yuzisun/ai-gateway
that referenced
this pull request
Jul 2, 2025
)" This reverts commit 1bed302. Signed-off-by: Dan Sun <dsun20@bloomberg.net>
mathetake
added a commit
that referenced
this pull request
Jul 2, 2025
**Description** We use REPLACE_AND_CONTINUE in the request header phase on the upstream extproc filter. However, the current extproc implementation removes the content-length header unconditionally when body mutation happens with REPLACE_AND_CONTINUE flag. This adds a workaround of that limitation by inserting the header mutation filter after the upstream extproc filter where we retrieve the content-length from a dynamic metadata. **Related Issues/PRs (if applicable)** Fixes the issue that the #730 resolves in different way --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts 65ca02a. It was introduced to avoid sending request bodies twice to the extrpoc. However, the current implementation of extproc in Envoy side will ALWAYS remove content-length header hence result in forcing the chunked transfer-encoding. That causes some issue with some AI providers as described in #721 for example.
Related Issues/PRs (if applicable)
Reverts #636
Fixes #721