Remove a test that uses UITester #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to add back a test that at least exercises the |
|
@flongford Do you have bandwidth to review? CI is unfortunately still failing because of an orthogonal issue, that's fixed separately in #1789. |
flongford
approved these changes
Apr 24, 2024
|
The issue with Python 3.8 and Python 3.9 no longer being available on macos-latest runners has been resolved upstream. I'm made a tiny commit to this PR to add "defusedxml" to the test dependencies - without this, some of the Sphinx tests were failing. If the CI passes, I'll merge. |
|
I've also updated the PR description. Merging! |
This was referenced Apr 30, 2024
mdickinson
added a commit
that referenced
this pull request
May 7, 2024
Since #1788, we have only one test module that makes use of the Qt event loop. That test module contains tests for the behaviour of handlers that use `dispatch='ui'` mechanism to redispatch off-thread notifications to the ui thread. This PR reworks that test module, with some significant collateral damage along the way. In detail: - reworks that test module (`test_ui_notifiers`) to avoid the need for the Qt event loop; instead, it tests against a `ui_handler` based on asyncio, which redispatches to the running asyncio event loop - adds a `get_ui_handler` counterpart to `set_ui_handler`, and exposes both functions in `traits.api` - adds type hints for `get_ui_handler` and `set_ui_handler` - removes two public module globals from `trait_notifiers`: `ui_handler` has been made private, while `ui_thread` is removed altogether - fixes a bug where ui dispatch didn't do the right thing (PR #1740 was incomplete; this bug should have been caught at review time on that PR) - makes another couple of drive-by cleanups, removing a very old check for `threading.local()` being a dict (which it hasn't been in living memory), and tidying up some uses of thread identity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a test that's using
UITesterfrom TraitsUI. This test exposed the Traits test suite to a class of possible issues with 3rd party GUI frameworks (in this case PySide6); historically,UITesterhas also been a particularly fragile part of TraitsUI.In its place is a test that at least executes the
Enum.create_editormethod, but doesn't attempt to create an instance of the editor.We also fix an issue with test dependencies and the latest release of Sphinx:
defusedxmlis now required to run the tests for the Traits documenter.Closes #1787