Skip to content

Commit

Permalink
Remove PySide as a test dependency (#1791)
Browse files Browse the repository at this point in the history
Since #1788 and #1792, we should no longer need a working Qt backend
when testing. Accordingly, this PR:

- removes PySide6 as a test dependency
- removes the need to `apt-get` Qt packages on Ubuntu runners
- removes the use of `xvfb-run` on Ubuntu runners
  • Loading branch information
mdickinson committed May 7, 2024
1 parent 2bc548f commit d80f450
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 26 deletions.
27 changes: 3 additions & 24 deletions .github/workflows/run-traits-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ on:
- pull_request
- workflow_dispatch

env:
# Temporary workaround prior to release of TraitsUI 8.0
# xref: enthought/traits#1742
ETS_QT4_IMPORTS: 1

jobs:
tests:
strategy:
Expand All @@ -20,19 +15,6 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: Install Linux packages for Qt support
run: |
sudo apt-get update
sudo apt-get install libegl1
sudo apt-get install libxkbcommon-x11-0
sudo apt-get install libxcb-cursor0
sudo apt-get install libxcb-icccm4
sudo apt-get install libxcb-image0
sudo apt-get install libxcb-keysyms1
sudo apt-get install libxcb-randr0
sudo apt-get install libxcb-render-util0
sudo apt-get install libxcb-shape0
if: matrix.os == 'ubuntu-latest'
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
Expand All @@ -44,9 +26,6 @@ jobs:
- name: Create clean test directory
run: |
mkdir testdir
- name: Test Traits package (Linux)
run: cd testdir && xvfb-run -a python -m unittest discover -v traits
if: matrix.os == 'ubuntu-latest'
- name: Test Traits package (Windows/macOS)
run: cd testdir && python -m unittest discover -v traits
if: matrix.os != 'ubuntu-latest'
- name: Test Traits package
run: python -m unittest discover -v traits
working-directory: testdir
1 change: 0 additions & 1 deletion etstool.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"lark-parser",
"mypy",
"numpy",
"pyside6",
"Sphinx",
"sphinx_copybutton",
"traitsui",
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ def get_long_description():
"mypy",
"numpy",
"pyface",
"PySide6",
"setuptools",
"Sphinx>=2.1.0",
"traitsui",
Expand Down

0 comments on commit d80f450

Please sign in to comment.